Feat/orchestrator pool validate improvement #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_improvement
branch
from
36ba486 to
8f7714c
Compare
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_improvement
branch
from
8f7714c to
1a3710f
Compare
nicoprow
approved these changes
Dec 14, 2023
martinfkaeser
suggested changes
Dec 15, 2023
There was a problem hiding this comment.
Apart from some minor remarks my main point is about the validateAddressesFromOrchestrator method and its sub-methods. I find the logic there quite confusing. Could you maybe have a look at it again and add some comments about the different cases?
And could you make sure you set the reformat option before commit because there are some weird spaces and indentations?
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskEntryBpnMapping.kt
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskEntryBpnMapping.kt
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/TaskEntryBpnMapping.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
bpdm-pool/src/main/kotlin/org/eclipse/tractusx/bpdm/pool/service/RequestValidationService.kt
Outdated
Show resolved
Hide resolved
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_improvement
branch
4 times, most recently
from
35b7fd4 to
b06626c
Compare
martinfkaeser
approved these changes
Dec 20, 2023
rainer-exxcellent
force-pushed
the
feat/orchestrator_pool_validate_improvement
branch
from
b06626c to
b29f7f9
Compare
…PN request identifier is known to the pool, the task has to be considered as update, - validate duplicates over all addresses and all legal entities - move function to create and compare business partner in own files
nicoprow
force-pushed
the
feat/orchestrator_pool_validate_improvement
branch
from
b29f7f9 to
6ed7859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the validation for the golden record process so that it: