Fix (Pool) - Added way to LegalAddress to be Main Site Address in Pool

[alexsilva-CGI]

Description

Currently, it is not possible in the Pool for a legal address to be also a main site address at the same time. This PR adjust the way a Address is persisted if both Legal Entity and Site share it.

Related issues: #657

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

• DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
• Copyright and license header are present on all affected files

[alexsilva-CGI]

@nicoprow Tested with the round trip, and it seems that its now associating both site and legalEntity to an address when the LegalAndSiteMainAddress is present on the AddressType.

I do have a question. Should also this logic apply when an update is done? so for example when type changes from SiteMainAddress to LegalAndSiteMainAddress, an association from both Site and Legal Entity to a single Address is done, with the deletion of the old persisted addresses. Thanks

[nicoprow]

@nicoprow Tested with the round trip, and it seems that its now associating both site and legalEntity to an address when the LegalAndSiteMainAddress is present on the AddressType.

I do have a question. Should also this logic apply when an update is done? so for example when type changes from SiteMainAddress to LegalAndSiteMainAddress, an association from both Site and Legal Entity to a single Address is done, with the deletion of the old persisted addresses. Thanks

For the update I would follow the same principle we have done before: The parent relationship between L/S/A business partners doesn't change

[nicoprow]

There is some duplicated code here. Why not somthing like:

val siteMainAddress = 
            if(genericBusinessPartner.postalAddress.addressType == AddressType.LegalAndSiteMainAddress) 
                legalEntity.legalAddress 
            else  
                createLogisticAddress(mainAddress, taskEntryBpnMapping)
        
  createSite.mainAddress = siteMainAddress
  siteMainAddress.site = createSite
  createSite

[nicoprow]

See the comment

[dilipdhankecha2530]

@nicoprow @alexsilva-CGI
We also need to think for the new endpoints which will do the same. In the current development there is no endpoint which we can use to create LegalEntity address as a SiteAddress.