Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool: LegalAddress can be Main Site Address #657

Closed
nicoprow opened this issue Nov 29, 2023 · 2 comments
Closed

Pool: LegalAddress can be Main Site Address #657

nicoprow opened this issue Nov 29, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicoprow
Copy link
Contributor

Currently, it is not possible in the Pool for a legal address to be also a main site address at the same time. However, according to the BPDM Gate and the golden record process this should be possible. We need to adapt the Pool so a legal address can be a site main address at the same time.

@nicoprow nicoprow added enhancement New feature or request Pool labels Nov 29, 2023
@nicoprow nicoprow moved this to New in BPDM Kanban Nov 29, 2023
@nicoprow nicoprow moved this from New to 📋 Backlog in BPDM Kanban Nov 29, 2023
@alexsilva-CGI alexsilva-CGI self-assigned this Nov 30, 2023
@alexsilva-CGI
Copy link
Contributor

I have some doubts regarding this @nicoprow . Currently if an Legal Entity is created and a Site, with the same Address information, two different rows are created on the DB with different BPN's and associations. It seems that it is possible the creation of an Address with both Legal Entity and Site as there are no constraints limiting that.

How would we go, logic wise, to adapt the pool to know if the associated legal address can also be an site main address? Probably by first checking if there similar addresses (Same values) persisted, or is there a field that can be used for this association?

@nicoprow
Copy link
Contributor Author

nicoprow commented Dec 5, 2023

I have some doubts regarding this @nicoprow . Currently if an Legal Entity is created and a Site, with the same Address information, two different rows are created on the DB with different BPN's and associations. It seems that it is possible the creation of an Address with both Legal Entity and Site as there are no constraints limiting that.

How would we go, logic wise, to adapt the pool to know if the associated legal address can also be an site main address? Probably by first checking if there similar addresses (Same values) persisted, or is there a field that can be used for this association?

The Pool doesn't need to infer by itself whether an address is a legal address and/or a site main address. It should be possible to read that from the orchestrator business partner when processing a golden record ticket. There, the address type clearly states whether the address is a legal address, site main address or both.

When it comes to the previous way on how we created business partners in the Pool through the POST and PUT endpoints, I don't think we need to support them anymore. The logic for them can be as is. This is just about the new integration logic with the orchestrator.

@alexsilva-CGI alexsilva-CGI moved this from 📋 Backlog to 🏗 In progress in BPDM Kanban Dec 5, 2023
@nicoprow nicoprow moved this from 🏗 In progress to ✅ Done in BPDM Kanban Dec 7, 2023
@nicoprow nicoprow closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants