Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cleaning-service-dummy) - Adjust the value 'HasChanged' Based on Address Type #660

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

alexsilva-CGI
Copy link
Contributor

@alexsilva-CGI alexsilva-CGI commented Nov 29, 2023

Description

This PR adjust the value 'HasChanged' Based on Address Type on cleaning-service-dummy

Related issues: #639

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@alexsilva-CGI alexsilva-CGI marked this pull request as ready for review November 29, 2023 16:41
@alexsilva-CGI
Copy link
Contributor Author

Hello @nicoprow . Is this logic wise what is intended regarding the #639 issue?

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for the cleaning service dummy

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but conflicts need to be resolved

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts, then its ready to be merged

@nicoprow nicoprow merged commit c786ac2 into eclipse-tractusx:main Dec 7, 2023
9 checks passed
@nicoprow nicoprow deleted the fix/has_changed_lsa branch December 7, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants