Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning Service Dummy: Adjust Set 'HasChanged' Based on Address Type #639

Closed
nicoprow opened this issue Nov 24, 2023 · 0 comments
Closed
Assignees

Comments

@nicoprow
Copy link
Contributor

Currently, in order to create a golden record business partner the cleaning service dummy just copies the generic address information to the legal, site main and additional address of the L/S/A representation. Additionally, for each L/S/A representation the dummy sets the field "hasChanged" to true, guaranteeing that the Pool overtakes these values as updates.

However, this behaviour means that we can't set a legal address which is different from site main address or additional address. They would always be the same, as they would be updated to the same information on each golden record process iteration.

Therefore, the cleaning service dummy should set the field "hasChanged" to true only for the L/S/A representation with a matching address type:
Legal Entity -> LegalAndSiteMainAddress or LegalAddress
Site -> LegalAndSiteMainAddress or SiteMainAddress
Address -> AdditionalAddress

@nicoprow nicoprow moved this to New in BPDM Kanban Nov 24, 2023
@nicoprow nicoprow moved this from New to 🔖 Ready in BPDM Kanban Nov 24, 2023
@alexsilva-CGI alexsilva-CGI self-assigned this Nov 27, 2023
@alexsilva-CGI alexsilva-CGI moved this from 🔖 Ready to 🏗 In progress in BPDM Kanban Nov 28, 2023
@alexsilva-CGI alexsilva-CGI moved this from 🏗 In progress to 👀 In review in BPDM Kanban Nov 30, 2023
@nicoprow nicoprow moved this from 👀 In review to ✅ Done in BPDM Kanban Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants