Feat: Add Reservation Endpoint to Orchestrator API #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
force-pushed
the
feat/orchestrator/cleaning-step-api
branch
from
19f02d7 to
5cd4929
Compare
2 tasks
nicoprow
changed the title
nicoprow
changed the title
2 tasks
nicoprow
force-pushed
the
feat/orchestrator/cleaning-step-api
branch
2 times, most recently
from
de5f7f5 to
ecae512
Compare
bpdm-common/src/main/kotlin/org/eclipse/tractusx/bpdm/common/dto/IBaseAddressSateDto.kt
Outdated
Show resolved
Hide resolved
...-orchestrator-api/src/main/kotlin/org/eclipse/tractusx/orchestrator/api/model/LegalEntity.kt
Outdated
Show resolved
Hide resolved
...-orchestrator-api/src/main/kotlin/org/eclipse/tractusx/orchestrator/api/model/LegalEntity.kt
Show resolved
Hide resolved
nicoprow
force-pushed
the
feat/orchestrator/cleaning-step-api
branch
from
ecae512 to
c61b4a0
Compare
- add DTO model for L/S/A business partners - connect endpoint with orchestrator controller - return static dummy data on endpoint invocation - add tests for validating endpoint invocation and dummy data return
nicoprow
force-pushed
the
feat/orchestrator/cleaning-step-api
branch
from
c61b4a0 to
2840146
Compare
|
Everything looks fine in my opinion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces an endpoint to reserve a given number of cleaning tasks from the orchestrator from a given cleaning step queue. For this I introduced interfaces for L/S/A DTOs in the common module an implemented those DTOs in the orchestrator application module, analogous to the generic business partner.
The API endpoint is implemented in the orchestrator controller and returns dummy data on invocation.
I also added tests checking the upsert limit and whether the endpoint can be invoked.
Contributes to #458
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: