Feat: Add Endpoint for Posting Cleaning Results to Orchestrator #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoprow
force-pushed
the
feat/orchestrator/cleaning-result-endpoint
branch
6 times, most recently
from
ae453b1 to
3627310
Compare
|
Rebased on top of main and ready to be reviewed |
bpdm-orchestrator-api/src/main/kotlin/org/eclipse/tractusx/orchestrator/api/CleaningTaskApi.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/org/eclipse/tractusx/bpdm/orchestrator/controller/CleaningTaskController.kt
Show resolved
Hide resolved
|
Besides my comments everythink looks good! |
- connect endpoint with orchestrator controller - return static dummy data on endpoint invocation - add tests for validating endpoint invocation and dummy data return - add test values for business partners
nicoprow
force-pushed
the
feat/orchestrator/cleaning-result-endpoint
branch
from
3627310 to
2e75c77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces an endpoint to post cleaning results for previously reserved cleaning tasks to the orchestrator. The API endpoint is implemented in the orchestrator controller and returns dummy data on invocation.
I also added tests checking the upsert limit and whether the endpoint can be invoked.
For the necessary test I created template objects for L/S/A business partners that can be used by the tests.
Solves issue #458
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: