Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpdm-gate): fetched and attached legal name of entity while performing partner upload process. #1142

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

SujitMBRDI
Copy link
Contributor

Description

In this pull request, we have added functionality for getting Legal Name from Pool service while performing partner upload process via CSV file. As per the standards, we should have legal name attached and now we are fetching legal name for particular legal entity based on tenantBpnl(User BPNL).

Fixes #1141

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI SujitMBRDI added bug Something isn't working enhancement New feature or request labels Dec 2, 2024
@SujitMBRDI SujitMBRDI added this to the BPDM v6.3.0 / R25.03. milestone Dec 2, 2024
@SujitMBRDI SujitMBRDI self-assigned this Dec 2, 2024
@SujitMBRDI SujitMBRDI marked this pull request as ready for review December 2, 2024 09:29
Copy link
Contributor

@kunyao-cofinity-x kunyao-cofinity-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@SujitMBRDI
Copy link
Contributor Author

Looks fine to me

Hi @kunyao-cofinity-x, thanks for reviewing!! If it all ok then could you please approve the pull request.
Otherwise, it will keep on showing me that i have some review comments to work on.
image

@kunyao-cofinity-x kunyao-cofinity-x self-requested a review December 2, 2024 11:11
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait I take it back :D

code looks good to me but please adhere to the commit convention and rename bugfix to fix

@dilipdhankecha2530
Copy link
Contributor

LGTM

@SujitMBRDI SujitMBRDI force-pushed the bugfix/legal-name-partner-upload branch from d944c8b to 3345cbc Compare December 3, 2024 05:42
@SujitMBRDI SujitMBRDI changed the title bugfix(bpdm-gate): fetched and attached legal name of entity while performing partner upload process. fix(bpdm-gate): fetched and attached legal name of entity while performing partner upload process. Dec 3, 2024
@SujitMBRDI
Copy link
Contributor Author

SujitMBRDI commented Dec 3, 2024

Wait I take it back :D

code looks good to me but please adhere to the commit convention and rename bugfix to fix

Hi @nicoprow, i have amended commit messgae and also edited the tittle.

@SujitMBRDI SujitMBRDI requested a review from nicoprow December 3, 2024 05:45
Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SujitMBRDI SujitMBRDI merged commit a043bdc into main Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

LegalName for Tasks created via the partner-upload-controller
4 participants