-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bpdm-gate): fetched and attached legal name of entity while performing partner upload process. #1142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
Hi @kunyao-cofinity-x, thanks for reviewing!! If it all ok then could you please approve the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait I take it back :D
code looks good to me but please adhere to the commit convention and rename bugfix
to fix
LGTM |
…rming partner upload process.
d944c8b
to
3345cbc
Compare
Hi @nicoprow, i have amended commit messgae and also edited the tittle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
In this pull request, we have added functionality for getting Legal Name from Pool service while performing partner upload process via CSV file. As per the standards, we should have legal name attached and now we are fetching legal name for particular legal entity based on tenantBpnl(User BPNL).
Fixes #1141
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: