Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegalName for Tasks created via the partner-upload-controller #1141

Closed
1 of 2 tasks
StWeisshaar opened this issue Nov 28, 2024 · 2 comments · Fixed by #1142
Closed
1 of 2 tasks

LegalName for Tasks created via the partner-upload-controller #1141

StWeisshaar opened this issue Nov 28, 2024 · 2 comments · Fixed by #1142
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@StWeisshaar
Copy link

StWeisshaar commented Nov 28, 2024

Description

As operator of BPDM,
I require the business partner object that can be reserved via the Orchestrator Task Worker to contain legalName or nameParts,
so that all relevant information is present.

Acceptance Criteria

  • legal entity information are fetched from the Pool based on the legalEntityBpn
  • nameParts and legalName are populated based on fetched information

Additional Information

The issue is relevant for the BP explorer context. The partner-upload-controller allows users to upload their sites and addresses. When using the csv upload feature you can not provide any legal entity information. The legal entity information for such a task is currently populated based on the BPNL that was used in authentication. Tasks created via the partner-upload-controller therefore do not contain a legalName or nameParts, but only contain a legalEntityBpn. Such tasks do not fulfill the mandatory field requirements and can create downstream issues.

Note: Using this endpoint companies will only be able to create sites and address for their own legal entity. This endpoint can not be used to create sites or addresses for any other legal entity. Even subsidiaries are excluded as they will generally have distinct BPNLs.

@StWeisshaar StWeisshaar added the enhancement New feature or request label Nov 28, 2024
@StWeisshaar StWeisshaar changed the title partner-upload-controller LegalName for Tasks created via the partner-upload-controller Nov 28, 2024
@StWeisshaar
Copy link
Author

@maximilianong @nicoprow Using the BP Explorer companies will only be able to create sites and addresses linked to the legal entity (BPNL) that is present in the authentication token. A parent company will not be able to manage sites and addresses for their subsidiaries using the same token. A separate token will be needed for each legal entity. Is this an intended restriction?

@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Nov 29, 2024
@nicoprow
Copy link
Contributor

@maximilianong @nicoprow Using the BP Explorer companies will only be able to create sites and addresses linked to the legal entity (BPNL) that is present in the authentication token. A parent company will not be able to manage sites and addresses for their subsidiaries using the same token. A separate token will be needed for each legal entity. Is this an intended restriction?

Actually for this version this is the intention as the CSV upload should be restricted to the company's own sites and adddresses. In later enhancements we may be able to also manage owned legal entities.

@nicoprow nicoprow moved this to New in BPDM Kanban Nov 29, 2024
@nicoprow nicoprow added the bug Something isn't working label Nov 29, 2024
@nicoprow nicoprow moved this from New to 🔖 Refined in BPDM Kanban Nov 29, 2024
@SujitMBRDI SujitMBRDI moved this from 🔖 Refined to 🏗 In progress in BPDM Kanban Dec 3, 2024
@SujitMBRDI SujitMBRDI moved this from 🏗 In progress to 👀 In review in BPDM Kanban Dec 3, 2024
@SujitMBRDI SujitMBRDI self-assigned this Dec 3, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in BPDM Kanban Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
3 participants