fix(charts): error on disabling subcharts #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- subcharts are now referenced with fullnameOverride
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes it possible to disable the postgres and the central-idp subcharts in the BPDM charts by fixing the default configuration. Now BPDM Charts can be deployed without having to deploy to its own postgres and central-idp next to it. If these subcharts are disabled it is necessary to specify an external postgres and central-idp in the Charts application configurations.
In order to work this fix now makes subcharts referenced by fullnameOverrides instead of just nameOverrides
Solves #1086
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: