BPDM Charts: Can't deploy with disabled Dependencies

[nicoprow]

Current Behavior

The BPDM Helm Charts currently come with Postgres and Central-IDP dependency. The Charts can be deployed as is. But if I want to use an external Postgres or Central-IDP and want to disable the dependencies the Charts won't render.

Expected Behavior

I can disable both Posgtres and Central-IDP.

Steps To Reproduce

Overwrite the BPDM default configuration by setting centralidp.enabled = false
When using

helm template -f your-values-file.yaml charts/bpdm

you will see an error.

Reasons

I already know why that problem exists. It is because of the helper functions in the bpdm-commons chart library:

{/*
Determine centralidp service/host name to connect to
*/}}
{{- define "bpdm.centralidpDependency" -}}
        {{- include "includeWithCentralidpContext" (list $ "centralidp.fullname") }}
{{- end }}}

{{/*
Invoke include on given definition with centralidp dependency context
Usage: include "includeWithCentralidpContext" (list $ "your_include_function_here")
*/}}
{{- define "includeWithCentralidpContext" -}}
{{- $ := index . 0 }}
{{- $function := index . 1 }}
{{- include $function (dict "Values" $.Values.centralidp "Chart" (dict "Name" "centralidp") "Release" $.Release "global" $.global) }}
{{- end }}

When the dependency is disabled the include $function command returns an error as the function is inside that dependency and not longer available for chart rendering.

Solution Suggestion

This behaviour makes it basically impossible to rely on invoking dependency functions from the parent. We would need to change strategy here for the Central-IDP and Postgres. Instead of invoking dependency functions I guess the only way is to copy or create own functions in the BPDM chart that infer the names of the dependencies.