Add @vscode/codicons
dependency to core package
#9828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #9826
Adds the
@vscode/codicons
package to the core Theia package. Currentlycodicons
are only available oncemonaco
has been loaded to the DOM. This loads anycodicons
at startup without the need to include monaco in Theia. I've confirmed that all currently usedcodicons
classes are contained in the referenced css file, except fortree-item-expanded
, which I've replaced withchevron-down
.cc @vince-fugnitto does this require a CQ?
How to test
monaco
packages. See the followingdependencies
section:Review checklist
Reminder for reviewers