#248 Fix Codicons dependency

[ndoschek]

Move "@vscode/codicons" from devDependencies to dependencies.

[planger]

Thanks, looks good to me! 👍

[spoenemann]

I'm thinking about whether we need to file a CQ for this dependency because it's CC-licensed. But since Theia is using it as well, it's probably not necessary. WDYT?

[tortmayr]

AFAIK the Eclipse foundation has changed their IP Policy and in general CQs are no longer required for third-party contents.
The corresponding section of the project handbook states the following:

• CQs are not required for third-party content in all cases.
• CQs are no longer required before third-party content is introduced.

So I think this PR is fine as is.

[spoenemann]

CQs are not required for third-party content in all cases.

That does not mean "CQs are not required in any case". There are still cases where you should file a CQ, for example if the license compatibility is uncertain.

[tortmayr]

I see, I misinterpreted that.
I had a loot at the PR that introduced the dependency in Theia. Apparently CC is part of the list of approved third party licenses so no CQ is required here.