plugin: add showDeprecated support
#9721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
monaco
vince-fugnitto
force-pushed
the
vf/showDeprecated
branch
from
346d103 to
46421ec
Compare
alvsan09
approved these changes
Jul 9, 2021
tsmaeder
reviewed
Jul 12, 2021
vince-fugnitto
force-pushed
the
vf/showDeprecated
branch
from
46421ec to
a0d5f78
Compare
The commit adds support for the `showDeprecated` monaco editor option which is contributed by language-servers to display deprecated strike-throughs in code which is deprecated. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/showDeprecated
branch
from
a0d5f78 to
7217aec
Compare
tsmaeder
approved these changes
Jul 13, 2021
dna2github
pushed a commit
to dna2fork/theia
that referenced
this pull request
Aug 25, 2021
The commit adds support for the `showDeprecated` monaco editor option which is contributed by language-servers to display deprecated strike-throughs in code which is deprecated. Signed-off-by: vince-fugnitto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8557
The pull-request adds support for the
editor.showDeprecatedpreference which styles deprecated code in editors with astrike-through. The diagnostic is contributed by language-servers:How to test
1.57.1in thepackage.json.theiaas a workspace folder.keymaps-service.tsand navigate to line140context(deprecated) should have the deprecated strike-through.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]