Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deprecated strikethrough directly in the editor #8557

Closed
DucNgn opened this issue Sep 24, 2020 · 2 comments · Fixed by #9721
Closed

Support deprecated strikethrough directly in the editor #8557

DucNgn opened this issue Sep 24, 2020 · 2 comments · Fixed by #9721
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco

Comments

@DucNgn
Copy link
Contributor

DucNgn commented Sep 24, 2020

Feature Description:

Would be nice if Theia highlights deprecated calls with strikethrough in the editor

  • Similar to VSCode:
    strikethrough
@vince-fugnitto vince-fugnitto added editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco labels Sep 24, 2020
@vince-fugnitto
Copy link
Member

I believe it will require an update to monaco v0.21.0 in order to make use of the showDeprecated flag:

https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.ieditoroptions.html#showdeprecated

@vince-fugnitto
Copy link
Member

The following should now be possible with the latest monaco upgrade.
The preference editor.showDeprecated is not yet supported at the moment (it does not display deprecations in the editor as is).

'editor.showDeprecated': {
'description': 'Controls strikethrough deprecated variables.',
'type': 'boolean',
'default': true
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants