Fix failing tests due to #9154 monaco upgrade 0.23.0

[EstherPerelman]

Signed-off-by: Esther Perelman [email protected]

What it does

Fixes: #9701

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[EstherPerelman]

I still haven't found a solution for the next issue:

[vince-fugnitto]

I still haven't found a solution for the next issue

@EstherPerelman any update regarding the last failing typescript test (run reference code lens)?

[EstherPerelman]

I still haven't found a solution for the next issue

@EstherPerelman any update regarding the last failing typescript test (run reference code lens)?

@vince-fugnitto I know where the problem is, but don't know how to solve it (still working on it).

[vince-fugnitto]

@EstherPerelman it's been a week now that the CI has been failing which means that new contributions have a failing CI, and next is not being published nightly. Perhaps if the test cannot be fixed soon, we can .skip it for the moment, and open an issue to track bringing it back?

[EstherPerelman]

@EstherPerelman it's been a week now that the CI has been failing which means that new contributions have a failing CI, and next is not being published nightly. Perhaps if the test cannot be fixed soon, we can .skip it for the moment, and open an issue to track bringing it back?

@vince-fugnitto It's really bad, I had some progress with it, It seems to be an error inside vsCode which checking for some condition before previous processes have been finished (that causes the condition to return false instead true), It happens only for the first time (what means that it's not so disturbing in real life),
There is also one more issue - as the link.dispatchEvent(new MouseEvent('mouseup', { bubbles: true })); not invoking (I clicked with the mouse and it worked),
I think it's a good idea to skip it until there will be a good solution...
WDYS?

[vince-fugnitto]

WDYS?

@EstherPerelman I think proceeding with the fixes you have and the .skip is fine for the moment to bring CI back (which I highlighted why is important). You can also create an issue to track bringing the .skip back with your findings and hopefully we can think of providing a solution for it.

[EstherPerelman]

@EstherPerelman I think proceeding with the fixes you have and the .skip is fine for the moment to bring CI back (which I highlighted why is important). You can also create an issue to track bringing the .skip back with your findings and hopefully we can think of providing a solution for it.

@vince-fugnitto added .skip & opened #9714 .

[vince-fugnitto]

Thank you for taking care of the test regressions and opening the follow-up #9714 👍