Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-test: test failure following monaco upgrade #9154 #9714

Closed
EstherPerelman opened this issue Jul 8, 2021 · 2 comments · Fixed by #9717
Closed

api-test: test failure following monaco upgrade #9154 #9714

EstherPerelman opened this issue Jul 8, 2021 · 2 comments · Fixed by #9717
Labels
help wanted issues meant to be picked up, require help monaco issues related to monaco test issues related to unit and api tests

Comments

@EstherPerelman
Copy link
Contributor

EstherPerelman commented Jul 8, 2021

Bug Description:

Following #9702 which resolved 2 of 3 errors.

Steps to Reproduce:

  1. Remove the .skip from this test
  2. From Theia root run command: yarn test:browser
  3. An error appears:
    image

Additional Information

  • Operating System: Windows
  • Theia Version: master
@vince-fugnitto vince-fugnitto added help wanted issues meant to be picked up, require help monaco issues related to monaco test issues related to unit and api tests labels Jul 8, 2021
@EstherPerelman
Copy link
Contributor Author

EstherPerelman commented Jul 8, 2021

@vince-fugnitto
As I wrote in #9702 comment:
There is a bug with vscode code, I am able to fix that by calling editor.getControl().getModel().applyEdits(..) twice, But it's not a real solution, What should I do?
Look at this - references text is shown only after applying the next edit in vscode:

Untitled-1.ts.-.vscode.-.Visual.Studio.Code.2021-07-08.19-37-11.mp4

@vince-fugnitto
Copy link
Member

@EstherPerelman given that it is for test purposes, perhaps you can perform multiple edits with a comment mentioning the behavior in vscode? If multiple edits are required for the codelens to appear for references I'm not sure what else we can do.

I do notice the same behavior as you, however, if the method is proper from the start it will display the codelens when restarting the app:

export function foo(): void {
    return;
}

EstherPerelman added a commit to EstherPerelman/theia that referenced this issue Jul 8, 2021
vince-fugnitto pushed a commit that referenced this issue Jul 12, 2021
dna2github pushed a commit to dna2fork/theia that referenced this issue Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help monaco issues related to monaco test issues related to unit and api tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants