api-test: fix file-search tests
#9693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit updates the `file-search` API tests following the monaco upgrade which introduced breaking changes to the way we deal with `QuickOpenItems`. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
file search
|
@EstherPerelman there are issues with the
These failures were also present on your commit to master. |
|
The problems related to There are still some problems related to upgrade Monaco - I think it should be fixed within a separate PR
|
RomanNikitenko
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9692
The commit updates the
file-searchAPI tests following the monaco upgrade which introduced breaking changes to the way we deal withQuickOpenItems.How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]