Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure in examples/api-tests/src/file-search.spec.js #9692

Closed
tsmaeder opened this issue Jul 2, 2021 · 3 comments · Fixed by #9693
Closed

Test failure in examples/api-tests/src/file-search.spec.js #9692

tsmaeder opened this issue Jul 2, 2021 · 3 comments · Fixed by #9693
Labels
file search issues related to the file search test issues related to unit and api tests

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Jul 2, 2021

After merging of #9154, we have a test failure due to a newly introduced test (see #9635).

My guess is we need to replace QuickOpenItem with QuickPickItem, but not sure.
@tsmaeder tsmaeder mentioned this issue Jul 2, 2021
Merged
1 task
@RomanNikitenko
Copy link
Contributor

quickOpenItem

@RomanNikitenko
Copy link
Contributor

quick_open

@tsmaeder tsmaeder changed the title Test failur in examples/api-tests/src/file-search.spec.js Test failure in examples/api-tests/src/file-search.spec.js Jul 2, 2021
@RomanNikitenko RomanNikitenko mentioned this issue Jul 2, 2021
Merged
1 task
@vince-fugnitto vince-fugnitto mentioned this issue Jul 2, 2021
Merged
1 task
@vince-fugnitto vince-fugnitto added file search issues related to the file search test issues related to unit and api tests labels Jul 2, 2021
@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Jul 2, 2021 •
edited
Loading

@tsmaeder @EstherPerelman
unfortunately, there are also failed tests not related to file-search
also, please see #9693 (comment)

tests_api

@EstherPerelman EstherPerelman mentioned this issue Jul 5, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
file search issues related to the file search test issues related to unit and api tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api-test: fix file-search tests eclipse-theia/theia
3 participants
@RomanNikitenko @tsmaeder @vince-fugnitto