Preserve cursor and selection when reopening editors #9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarSdt-EC
force-pushed
the
os/feature_preserveCursorPR
branch
2 times, most recently
from
1349ba5 to
7acb2b7
Compare
OmarSdt-EC
changed the title
vince-fugnitto
added
enhancement
alvsan09
approved these changes
Jun 8, 2021
OmarSdt-EC
force-pushed
the
os/feature_preserveCursorPR
branch
from
7acb2b7 to
f687540
Compare
The cursor or the selection is now preserved when we close an editor and when we use ctrlcmd + p to reopen it. It stays at the location where we left it and doesn't end up at the beginning of the file like before.
OmarSdt-EC
force-pushed
the
os/feature_preserveCursorPR
branch
from
f687540 to
c7f5eeb
Compare
vince-fugnitto
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
I confirmed that the changes work as intended:
- the editor state is restored if available when performing
quick-file-open. - the editor state is not preserved if an explicit selection (line number or line number + column) is explicitly requested when opening.
- the editor state is restored if the
editor.history.persistClosedEditorsis set totrueand we attempt to re-open a previously stored editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6016
Fixes #8782
The pull-request attempts to restore the previous editor state when re-opening a closed editor through the
quick-file-open.The editor-view state should preserve folding, selection, cursor location.
How to test
Selection:
Folding:
fold all(the folding regions of the editor should be collapsed).Line and Column:
Thanks to #9478, it is now possible to open files with a pre-defined line number and column. If the line number, or line number and column are provided this should take precedence over restoring the editor.
Review checklist
Reminder for reviewers