Support quick file-search with go to line

[alvsan09]

What it does

The quick file-search text box (normally accessed via Ctrl + P)
now allows the option to append filter input separators to indicate
the target line number and column. This follows the current vscode
patterns.

E.g.
:<line number?>:<column?>
#<line number?>#<column?>
:<line number?>,<column?>

Fixes: #9476.

How to test

The 'gif' attached shows the new facility available in the quick file-search box, verify that:

• The input box now indicates the option to 'append : to go to line'.
• type a file path pattern, append ':' and a line number. Check that the selected file is opened at the given line number.
• Adding alphabetical characters instead of numerical for the go to line number are ignored.
• type a file path pattern, append ':' for the line number and a second separator ':' for the column. Check that the selected file is opened at the given line number and column.
• Use '#' character as separators and repeat the check.
• the ',' comma character can be used as well as an alternative separator for column.
• Search with no file filter simply line and column (e.g. :15:4) and verify that the currently selected file opens at the given location.
• Verify that entering a file filter with no line number navigates to the top of the file (regression test).
• Make sure that file filter searches with spaces continue to work with and without given line and column.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Alvaro Sanchez-Leon [email protected]

[vince-fugnitto]

I confirmed that the changes work well functionality 👍
I have some minor comments about variable names, let me know if you disagree.

[vince-fugnitto]

The changes work correctly for me, and I verified the code as well 👍

• verified pattern:line format.
• verified pattern:line:column format.
• verified pattern:line,column format.

Offline we spoke about a potential future improvement where we open the editor with a buffer (display previous content) instead of the selected line being the first in the document. Would you mind opening an issue to track this feature once the pull-request is merged?

[alvsan09]

Offline we spoke about a potential future improvement where we open the editor with a buffer (display previous content) instead of the selected line being the first in the document. Would you mind opening an issue to track this feature once the pull-request is merged?

The issue #9495 is now created to follow up and address this pending issue.

[alvsan09]

@vince-fugnitto, @marechal-p,
is there anything pending in this PR before moving forward?

[emilyann211]

[vince-fugnitto]

@emilyann211 did you comment by accident?