custom-editor: remove 'editor-preview` coupling #9302
Merged
+1
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9300
The following pull-request updates the breaking changes introduced by #8910 (support for
custom-editors
) which included new coupling to@theia/editor-preview
. The coupling meant that downstream applications would unnecessarily pull@theia/editor-preview
without expecting it, and would not be able to easily opt-out (or would require new customizations).The changes include removing the dependency, and removing the unused typing as part of the
canHandle
since it was unused.How to test
custom-editors
still work correctly (using the vscode-cat-customs plugin).Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com