Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-editor: remove 'editor-preview` coupling #9302

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #9300

The following pull-request updates the breaking changes introduced by #8910 (support for custom-editors) which included new coupling to @theia/editor-preview. The coupling meant that downstream applications would unnecessarily pull @theia/editor-preview without expecting it, and would not be able to easily opt-out (or would require new customizations).

The changes include removing the dependency, and removing the unused typing as part of the canHandle since it was unused.

How to test

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

Sorry, something went wrong.

The following commit removes the unnecessary coupling to
`@theia/editor-preview` from `custom-editor` functionality contributed
by the plugin-system.

Adding the coupling was a breaking change for downstream applications
who were not expecting `@theia/editor-preview` from being contributed,
and meant it was difficult to opt-out.

The coupling was introduced to add unused typing so it is safe to
remove.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added quality issues related to code and application quality custom-editor issues related to custom-editor functionality labels Apr 6, 2021
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch.

@vince-fugnitto vince-fugnitto merged commit b0ed2ac into master Apr 8, 2021
@vince-fugnitto vince-fugnitto deleted the vf/fix-custom-editor branch April 8, 2021 14:35
@github-actions github-actions bot added this to the 1.13.0 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-editor issues related to custom-editor functionality quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom-editor: changeset unnecessarily pulls '@theia/editor-preview'
2 participants