custom-editor: remove 'editor-preview` coupling

The following commit removes the unnecessary coupling to `@theia/editor-preview` from `custom-editor` functionality contributed by the plugin-system. Adding the coupling was a breaking change for downstream applications who were not expecting `@theia/editor-preview` from being contributed, and meant it was difficult to opt-out. The coupling was introduced to add unused typing so it is safe to remove. Signed-off-by: vince-fugnitto <[email protected]>
eclipse-theia · Apr 8, 2021 · b0ed2ac · b0ed2ac
1 parent 85bffae
commit b0ed2ac
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/packages/plugin-ext/compile.tsconfig.json b/packages/plugin-ext/compile.tsconfig.json
@@ -73,9 +73,6 @@
     },
     {
       "path": "../workspace/compile.tsconfig.json"
-    },
-    {
-      "path": "../editor-preview/compile.tsconfig.json"
     }
   ]
 }
diff --git a/packages/plugin-ext/package.json b/packages/plugin-ext/package.json
@@ -10,7 +10,6 @@
     "@theia/core": "1.12.0",
     "@theia/debug": "1.12.0",
     "@theia/editor": "1.12.0",
-    "@theia/editor-preview": "1.12.0",
     "@theia/file-search": "1.12.0",
     "@theia/filesystem": "1.12.0",
     "@theia/markers": "1.12.0",

diff --git a/packages/plugin-ext/src/main/browser/custom-editors/custom-editor-opener.tsx b/packages/plugin-ext/src/main/browser/custom-editors/custom-editor-opener.tsx
@@ -15,7 +15,6 @@
  ********************************************************************************/
 
 import { inject } from '@theia/core/shared/inversify';
-import { PreviewEditorOpenerOptions } from '@theia/editor-preview/lib/browser';
 import URI from '@theia/core/lib/common/uri';
 import { ApplicationShell, OpenerOptions, OpenHandler, Widget, WidgetManager } from '@theia/core/lib/browser';
 import { CustomEditorPriority, CustomEditorSelector } from '../../../common';
@@ -42,7 +41,7 @@ export class CustomEditorOpener implements OpenHandler {
         this.label = this.editor.displayName;
     }
 
-    canHandle(uri: URI, options?: PreviewEditorOpenerOptions): number {
+    canHandle(uri: URI): number {
         if (this.matches(this.editor.selector, uri)) {
             return this.getPriority();
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -73,9 +73,6 @@ @@
         },
         {
           "path": "../workspace/compile.tsconfig.json"
-        },
-        {
-          "path": "../editor-preview/compile.tsconfig.json"
         }
       ]
     }