complete arguments in addEventListener function #9273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
requested changes
Mar 29, 2021
There was a problem hiding this comment.
@ahaWDY thank you for the contribution 👍
Unfortunately, in order to accept the changes the sign-off should be updated as the current one is invalid based on project guidelines. We do not accept anonymous contributions (ex: github-noreply).
Use your real name (sorry, no pseudonyms or anonymous contributions.)
Signed-off-by: ahaWDY <[email protected]> complete arguments in addEventListener function
Thank you for your reply! I have updated the author and sign-off information. |
vince-fugnitto
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahaWDY [email protected]
What it does
complete arguments of addEventListener function and fix #9250
How to test
The argument "useCapture" is used in the addEventListener function, so it should also add to the removeEventListener function
Review checklist
Reminder for reviewers