Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the function of addEventListener has a bug #9250

Closed
gpsbird opened this issue Mar 25, 2021 · 1 comment · Fixed by #9273
Closed

the function of addEventListener has a bug #9250

gpsbird opened this issue Mar 25, 2021 · 1 comment · Fixed by #9273
Labels
core issues related to the core of the application good first issue good first issues for new contributors quality issues related to code and application quality

Comments

@gpsbird
Copy link

gpsbird commented Mar 25, 2021 •
edited
Loading

Bug Description:

The argument "useCapture" is used in the addEventListener function, so it should also appears in the removeEventListener function
widget

Additional Information

  • Operating System:
  • Theia Version: master
@vince-fugnitto vince-fugnitto added core issues related to the core of the application quality issues related to code and application quality labels Mar 25, 2021
@vince-fugnitto
Copy link
Member

@gpsbird thank you for reporting the issue, do you mind providing a pull-request to resolve it?

@vince-fugnitto vince-fugnitto added the good first issue good first issues for new contributors label Mar 25, 2021
@ahaWDY ahaWDY mentioned this issue Mar 29, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core issues related to the core of the application good first issue good first issues for new contributors quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

complete arguments in addEventListener function ahaWDY/theia
2 participants
@gpsbird @vince-fugnitto