-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix context-keys ScmProvider update, add submenu plugin contribution #8996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the submenus present in the scm
view with the builtin git extensions (both git
and git-ui
) are now populated 👍
@vince-fugnitto I've reworked this PR to hanle multiple nestance level of the submenus. To test it you should add such submenu contribution to the
|
6bb4ec2
to
9328275
Compare
@vinokurig thank you, I'll take a look at the changes shortly 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig I confirmed that the pull-request works well with:
- the
vscode-builtin-git
extension now successfully contributing submenus - the nested submenu example you provided Fix context-keys ScmProvider update, add submenu plugin contribution #8996 (comment)
I'm not sure if you want others to review the changes as well.
Signed-off-by: Igor Vinokur <[email protected]>
Signed-off-by: Igor Vinokur [email protected]
What it does
Fixes #8724
ScmProvider
context-keys on SCM widget start to handle properly thewhen
condition of the related menu items.SCM
view.How to test
"@theia/git": "^1.9.0"
fromexamples/browser/package.json
file.plugins
folder....
drop-down menu.See:
Review checklist
Reminder for reviewers