Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] Group the context menu items per Git command #8400

Closed
kittaakos opened this issue Aug 18, 2020 · 6 comments
Closed

[git] Group the context menu items per Git command #8400

kittaakos opened this issue Aug 18, 2020 · 6 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git help wanted issues meant to be picked up, require help scm issues related to the source control manager

Comments

@kittaakos
Copy link
Contributor

The latest VS Code has the context menu items logically grouped by the corresponding Git command. We could do something similar.

VS Code:
Screen Shot 2020-08-18 at 14 59 36

Theia:
Screen Shot 2020-08-18 at 15 00 06

Feature Description:

@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help git issues related to git scm issues related to the source control manager labels Aug 18, 2020
@alexandrosyiangou
Copy link

@kittaakos Hey there! I would like to try this if possible! 🙂 Can you assign this on me please?

@kittaakos
Copy link
Contributor Author

I would like to try this if possible!

Great!

Can you assign this on me please?

It's yours, go ahead.

@alexandrosyiangou
Copy link

Just a quick question.
Would you like the grouping to be like VSCode, I mean with secondary menus for each category?
Or would you like to keep your current design of seperating each category with a line?

@kittaakos
Copy link
Contributor Author

Would you like the grouping to be like VSCode, I mean with secondary menus for each category?

I would do the same what VS Code does; group them by the Git command.

@akosyakov, @vince-fugnitto what do you think?

@vince-fugnitto
Copy link
Member

Would you like the grouping to be like VSCode, I mean with secondary menus for each category?

I would do the same what VS Code does; group them by the Git command.

@akosyakov, @vince-fugnitto what do you think?

Sorry I must have missed the ping, I assume you are talking about the @theia/git extension?
The plugin API has been updated to support the same behavior as vscode with the changes proposed in #8996.

kittaakos pushed a commit that referenced this issue Apr 26, 2021
Update packages/git/src/browser/git-contribution.ts
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Dennis Hübner <dennis.huebner@gmail.com>
@vince-fugnitto
Copy link
Member

Closed thanks to #9324

dna2github pushed a commit to dna2fork/theia that referenced this issue Aug 25, 2021
Update packages/git/src/browser/git-contribution.ts
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>

Signed-off-by: Dennis Hübner <dennis.huebner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git help wanted issues meant to be picked up, require help scm issues related to the source control manager
Projects
None yet
Development

No branches or pull requests

3 participants