download-plugins: report a failure in case of unsupported file type #8797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
paul-marechal
approved these changes
Nov 30, 2020
vince-fugnitto
added
builtins
|
@perrinjerome do you mind rebasing this pull-request as well to the latest |
If a plugin url listed in theiaPlugins in package.json is not supported, it should be reported as a failure and not only logged. Signed-off-by: Jérome Perrin <[email protected]>
perrinjerome
force-pushed
the
fix/download-plugin-unsupported
branch
from
06ce66c to
395dbbb
Compare
|
@vince-fugnitto Thank you, I just rebased on master |
vince-fugnitto
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
If a plugin url listed in theiaPlugins in package.json is not supported,
it should be reported as a failure and not only logged.
How to test
Change
theiaPluginsin package.json to have an incorrect extensionRun
yarn download:plugins, an error should be reported ( with #8788 is applied, the build should fail )Review checklist
Reminder for reviewers