download-plugins: report a failure in case of unsupported file type

If a plugin url listed in theiaPlugins in package.json is not supported, it should be reported as a failure and not only logged. Signed-off-by: Jérome Perrin <[email protected]>
eclipse-theia · Dec 7, 2020 · 395dbbb · 395dbbb
1 parent 763d3ba
commit 395dbbb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/dev-packages/cli/src/download-plugins.ts b/dev-packages/cli/src/download-plugins.ts
@@ -108,7 +108,7 @@ async function downloadPluginAsync(failures: string[], plugin: string, pluginUrl
     } else if (pluginUrl.endsWith('vsix')) {
         fileExt = '.vsix';
     } else {
-        console.error(red(`error: '${plugin}' has an unsupported file type: '${pluginUrl}'`));
+        failures.push(red(`error: '${plugin}' has an unsupported file type: '${pluginUrl}'`));
         return;
     }
     const targetPath = path.join(process.cwd(), pluginsDir, `${plugin}${packed === true ? fileExt : ''}`);