[Fix] Webview is covered with transparent overlay when clicking inside it

[shahar-h]

Signed-off-by: Shahar Harari [email protected]

What it does

When clicking inside webviews a mousedown event is dispatched on webview node. This logic was added #8633 in order to fix #7752.
The problem is that eventually also application shell mousedown event is fired, which causes the webview to be covered by a transparent overlay:

theia/packages/plugin-ext/src/main/browser/webview/webview.ts

Lines 187 to 191 in d295e46

	this.toDispose.push(this.mouseTracker.onMousedown(() => {
	if (this.element && this.element.style.display !== 'none') {
	this.transparentOverlay.style.display = 'block';
	}
	}));

This transparent overlay disrupts interaction with webview UI.

The solution is to dispatch the mousedown event on document instead of on webview node, and by that prevent the application shell mousedown event from being fired.

Fixes #8702. There can also be similar issues with other webviews.

How to test

• See described steps is [Regression] Application Wizard Vs Code extension is broken on 1.7.0 #8702.
• Check that menus are still closing when clicking inside webviews. see described steps in Menu not collapsed when clicking on webviews  #7752.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@shahar-h thank you for taking care of the issue 👍

I verified the pull-request by:

• confirmed the bug on master using the SAP Application Wizard extension ([Regression] Application Wizard Vs Code extension is broken on 1.7.0 #8702)
• confirmed that [Regression] Application Wizard Vs Code extension is broken on 1.7.0 #8702 is resolved - I am now able to choose an extension type
• confirmed that the fix for Menu not collapsed when clicking on webviews  #7752 still works correctly - dismissing menus when clicking within webviews

[shahar-h]

@vince-fugnitto Some tests are failing, not sure if it's related to me:

[vince-fugnitto]

@vince-fugnitto Some tests are failing, not sure if it's related to me:

They're not :) #8681

[shahar-h]

@vince-fugnitto Can you please retrigger the build?

[vince-fugnitto]

@vince-fugnitto Can you please retrigger the build?

Passed :)

[shahar-h]

Thanks @vince-fugnitto :)

[vince-fugnitto]

Thanks @vince-fugnitto :)

I'll merge tomorrow if there are no objections 👍