[FIX] menus are not closed when clicking inside webviews

[shahar-h]

Signed-off-by: Shahar Harari [email protected]

What it does

Menus are now closed when clicking inside webviews.
In order to achieve this mousedown event needs to be dispatched to main window.
Fixes #7752

How to test

See described steps in #7752.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@shahar-h do you mind updating the pull-request to not include unnecessary changes (formatting)?

[vince-fugnitto]

Please note that there is already an open pull-request which attempts to resolve the issue: #8576.

[shahar-h]

@shahar-h do you mind updating the pull-request to not include unnecessary changes (formatting)?

Sorry for that, VS Code converted all tabs to spaces, reverted all unrelated changes.

[shahar-h]

Please note that there is already an open pull-request which attempts to resolve the issue: #8576.

I know, I'm trying to address only #7752 with a different approach.

[shahar-h]

@vince-fugnitto Windows build is failing with:

Downloading tarball...
Failed to download https://yarnpkg.com/downloads/1.13.0/yarn-v1.13.0.tar.gz.
The command "curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.13.0" failed and exited with 1 during .

The formatting changes were reverted.

[shahar-h]

@vince-fugnitto this PR attempts to resolve only #7752 without breaking other functionality.
Can we go forward with it?

[vince-fugnitto]

@shahar-h the following pull-request introduces a flickering bug when navigating menus which I believe the previous pull-request attempted to address. For example, you can see how not only the tab flickers, but also the toolbar items which gives a bad user experience:

[shahar-h]

the following pull-request introduces a flickering bug when navigating menus which I believe the previous pull-request attempted to address.

This issue is not related to my PR, it is also reproduced on master.

[vince-fugnitto]

the following pull-request introduces a flickering bug when navigating menus which I believe the previous pull-request attempted to address.

This issue is not related to my PR, it is also reproduced on master.

@shahar-h this is master, the toolbar items on master do not flicker (disappear and reappear completely):

As compared to the pull-request:

[shahar-h]

@vince-fugnitto I'm not sure how you checked, I've just reproduced the same behavior on master:

BTW, is there any reason there are two Open Preview to the Side buttons?

[vince-fugnitto]

@vince-fugnitto I'm not sure how you checked, I've just reproduced the same behavior on master:

I was able to reproduce more consistently on master as well 👍

BTW, is there any reason there are two Open Preview to the Side buttons?

There are two items since we provide the functionality from @theia/preview and the builtin extension (plugin).
In an actual application, we'd only choose one extension to provide the functionality: #6984

[vince-fugnitto]

Functionally the changes work very well 👍
I'll open a follow-up issue regarding the webview stealing focus and how toolbar items flicker.

[paul-marechal]

LGTM otherwise.