GH-7838: Fixed task execution on macOS with zsh.
#7889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexTugarev, there is not much to review on this PR, if you can run the |
akosyakov
added
process
paul-marechal
approved these changes
May 26, 2020
| @@ -150,8 +148,4 @@ export class ShellCommandBuilder { | |||
| return command; | |||
| } | |||
|
|
|||
| protected buildForDefault(args: Array<string | ShellQuotedString>, cwd?: string, env?: Array<[string, string | null]>): string { | |||
There was a problem hiding this comment.
nitpick: Can you keep this default function, but make it call the bash one? Makes it easier to override if someone needs/wants to.
added 2 commits
May 26, 2020 16:56
Switched to Xcode `11.4` on Travis CI to support macOS `10.15.4`. Closes #7838. Signed-off-by: Akos Kitta <[email protected]>
Do not expect to receive the test expectation as the first messages from the terminal. Signed-off-by: Akos Kitta <[email protected]>
|
I made the requested changes. Thank you for the review! I also did change (6822129) one of the test assertions; it's a bit more robust now. I found an issue with the expectation after switching macs. The terminal popped up with a warning (this is expected and related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to Xcode
11.4on Travis CI to support macOS10.15.4.Closes #7838.
Signed-off-by: Akos Kitta [email protected]
What it does
How to test
Review checklist
Reminder for reviewers