GH-7838: Fixed task execution on macOS with zsh.

Switched to Xcode `11.4` on Travis CI to support macOS `10.15.4`.

Closes #7838.

Signed-off-by: Akos Kitta <[email protected]>

.travis.yml

@@ -115,6 +115,7 @@ jobs:
     - stage: test
       os: linux
     - os: osx
+      osx_image: xcode11.4
       env: CXX=c++
       before_script: skip
       script:

packages/process/src/common/shell-command-builder.ts

@@ -77,9 +77,7 @@ export class ShellCommandBuilder {
                 return this.buildForCmd(args, cwd, env);
             }
         }
-        // If we cannot detect which shell is being used, don't escape.
-        console.warn(`Unknown shell, could not escape arguments: ${host || 'undefined'}`);
-        return this.buildForDefault(args, cwd, env);
+        return this.buildForBash(args, cwd, env);
     }
 
     protected buildForBash(args: Array<string | ShellQuotedString>, cwd?: string, env?: Array<[string, string | null]>): string {
@@ -150,8 +148,4 @@ export class ShellCommandBuilder {
         return command;
     }
 
-    protected buildForDefault(args: Array<string | ShellQuotedString>, cwd?: string, env?: Array<[string, string | null]>): string {
-        return args.join(' ');
-    }
-
 }

packages/task/src/node/process/process-task-runner.ts

@@ -190,6 +190,10 @@ export class ProcessTaskRunner implements TaskRunner {
             } else if (/(ps|pwsh|powershell)(.exe)?/.test(command)) {
                 quotingFunctions = PowershellQuotingFunctions;
                 execArgs = ['-c'];
+            } else {
+                quotingFunctions = BashQuotingFunctions;
+                execArgs = ['-l', '-c'];
+
             }
             // Allow overriding shell options from task configuration.
             if (shell && shell.args) {

packages/task/test-resources/task-long-running-osx

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 for i in {1..300}
 do

packages/task/test-resources/task-osx

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 
 for i in $@
 do