set focus to terminal that the attached task is running from #7452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Mar 31, 2020
akosyakov
added
tasks
elaihau
force-pushed
the
Liang/attachTaskNotNewWidget
branch
from
74f9738 to
444f517
Compare
elaihau
force-pushed
the
Liang/attachTaskNotNewWidget
branch
from
444f517 to
98216b5
Compare
- Same task can be attached over and over again, producing multiple terminal widgets. With this change, Theia sets focus to the teminal widget that the to-be-attached task is running from. If such terminal widget is not found, Theia creates a new terminal widget for the attached task. - fixes #7407 Signed-off-by: Liang Huang <[email protected]>
elaihau
force-pushed
the
Liang/attachTaskNotNewWidget
branch
from
98216b5 to
03962bf
Compare
RomanNikitenko
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same task can be attached over and over again, producing multiple terminal widgets. With this change, Theia sets focus to the teminal widget that the to-be-attached task is running from. If such terminal widget is not found, Theia creates a new terminal widget for the attached task.
fixes attaching the same task repeatedly should not open multiple terminals #7407
Signed-off-by: Liang Huang [email protected]
How to test
Expected: Theia does not open new terminals in Step 4.
Review checklist