Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attaching the same task repeatedly should not open multiple terminals #7407

Closed
elaihau opened this issue Mar 23, 2020 · 1 comment · Fixed by #7452
Closed

attaching the same task repeatedly should not open multiple terminals #7407

elaihau opened this issue Mar 23, 2020 · 1 comment · Fixed by #7452
Assignees
@elaihau
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@elaihau
Copy link
Contributor

elaihau commented Mar 23, 2020

Description

Same task can be attached over and over again, producing multiple terminal widgets.
Since we disallow running identical tasks in parallel (#5269), we should not open more than one terminal widget when the same task is attached for a second time.

Reproduction Steps

  1. Open workspace, start a long running task
  2. open a another tab pointing to the same workspace.
  3. While the task started in Step 1 is still running, do Terminal -> Attach Task from the browser opened in Step 2.
  4. Repeat Step 3 multiple times. Theia creates a new terminal widget every time.

Peek 2020-03-23 16-52

OS and Theia version:

Ubuntu 18.04. Chrome, example browser.
version 9d59a4e
@elaihau elaihau added the tasks issues related to the task system label Mar 23, 2020
@elaihau elaihau self-assigned this Mar 23, 2020
@elaihau elaihau changed the title same task should not be attached multiple times attaching the same task should not open multiple terminals Mar 23, 2020
@elaihau elaihau added the bug bugs found in the application label Mar 23, 2020
@elaihau elaihau changed the title attaching the same task should not open multiple terminals attaching the same task repeatedly should not open multiple terminals Mar 23, 2020
@elaihau
Copy link
Contributor Author

elaihau commented Mar 23, 2020 •
edited
Loading

I believe what we could do is setting focus to the terminal widget where that attached task is running, and messaging the user.

@elaihau elaihau mentioned this issue Mar 24, 2020
Merged
1 task
elaihau added a commit that referenced this issue Mar 30, 2020
@elaihau
set focus to terminal that the attached task is running from
74f9738 
- Same task can be attached over and over again, producing multiple terminal widgets. With this change, Theia sets focus to the teminal widget that the to-be-attached task is running from. If such terminal widget is not found, Theia creates a new terminal widget for the attached task.

- fixes #7407

Signed-off-by: Liang Huang <[email protected]>
@elaihau elaihau mentioned this issue Mar 30, 2020
Merged
1 task
elaihau added a commit that referenced this issue Apr 1, 2020
@elaihau
set focus to terminal that the attached task is running from
444f517 
- Same task can be attached over and over again, producing multiple terminal widgets. With this change, Theia sets focus to the teminal widget that the to-be-attached task is running from. If such terminal widget is not found, Theia creates a new terminal widget for the attached task.

- fixes #7407

Signed-off-by: Liang Huang <[email protected]>
elaihau added a commit that referenced this issue Apr 1, 2020
@elaihau
set focus to terminal that the attached task is running from
98216b5 
- Same task can be attached over and over again, producing multiple terminal widgets. With this change, Theia sets focus to the teminal widget that the to-be-attached task is running from. If such terminal widget is not found, Theia creates a new terminal widget for the attached task.

- fixes #7407

Signed-off-by: Liang Huang <[email protected]>
elaihau added a commit that referenced this issue Apr 2, 2020
@elaihau
set focus to terminal that the attached task is running from
03962bf 
- Same task can be attached over and over again, producing multiple terminal widgets. With this change, Theia sets focus to the teminal widget that the to-be-attached task is running from. If such terminal widget is not found, Theia creates a new terminal widget for the attached task.

- fixes #7407

Signed-off-by: Liang Huang <[email protected]>
elaihau added a commit that referenced this issue Apr 4, 2020
@elaihau
set focus to terminal that the attached task is running from
2c16d4e 
- Same task can be attached over and over again, producing multiple terminal widgets. With this change, Theia sets focus to the teminal widget that the to-be-attached task is running from. If such terminal widget is not found, Theia creates a new terminal widget for the attached task.

- fixes #7407

Signed-off-by: Liang Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set focus to terminal that the attached task is running from eclipse-theia/theia
1 participant
@elaihau