Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: fix misc typos #7409

Merged
merged 1 commit into from
Mar 26, 2020
Merged

repo: fix misc typos #7409

merged 1 commit into from
Mar 26, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

This commit fixes a number of typos present in different extensions.
There are a few notable potential breaking updates:

  • [debug] renamed debuggingStaturBar to debuggingStatusBar
  • [plugin] renamed CancelationTokenImpl to CancellationTokenImpl
  • [plugin] renamed VIEW_ITEM_INLINE_MNUE to VIEW_ITEM_INLINE_MENU
  • [terminal] renamed handleWroleWordOptionClicked to handleWholeWordOptionClicked
  • [workspace] renamed toDiposeOnUpdateCurrentWidget to toDisposeOnUpdateCurrentWidget

How to test

  1. CI should pass (build & test)
  2. Verify typo fixes

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality documentation issues related to documentation labels Mar 24, 2020
@vince-fugnitto vince-fugnitto self-assigned this Mar 24, 2020
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that a lot of typos; a couple need a second look but otherwise good.

@vince-fugnitto vince-fugnitto force-pushed the vf/typo-updates branch 2 times, most recently from 7b2c3ad to a89f66d Compare March 24, 2020 13:11
@marcdumais-work
Copy link
Contributor

@vince-fugnitto feel free to merge when you're ready

@vince-fugnitto
Copy link
Member Author

@vince-fugnitto feel free to merge when you're ready

I thought of giving more time to see if people were against the small breaking changes or not.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these breaking changes doesn't break che :-)

@vince-fugnitto vince-fugnitto force-pushed the vf/typo-updates branch 3 times, most recently from dd316fd to b03b3ac Compare March 25, 2020 15:57
This commit fixes a number of typos present in different extensions.
There are a few notable potential breaking updates:
- [debug] renamed `debuggingStaturBar` to `debuggingStatusBar`
- [plugin] renamed `CancelationTokenImpl` to `CancellationTokenImpl`
- [plugin] renamed `VIEW_ITEM_INLINE_MNUE` to `VIEW_ITEM_INLINE_MENU`
- [terminal] renamed `handleWroleWordOptionClicked` to `handleWholeWordOptionClicked`
- [workspace] renamed `toDiposeOnUpdateCurrentWidget` to `toDisposeOnUpdateCurrentWidget`

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto merged commit f5433ec into master Mar 26, 2020
@vince-fugnitto vince-fugnitto deleted the vf/typo-updates branch March 26, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants