Skip to content

Commit

Permalink
repo: fix misc typos
Browse files Browse the repository at this point in the history
This commit fixes a number of typos present in different extensions.
There are a few notable potential breaking updates:
- [debug] renamed `debuggingStaturBar` to `debuggingStatusBar`
- [plugin] renamed `CancelationTokenImpl` to `CancellationTokenImpl`
- [plugin] renamed `VIEW_ITEM_INLINE_MNUE` to `VIEW_ITEM_INLINE_MENU`
- [terminal] renamed `handleWroleWordOptionClicked` to `handleWholeWordOptionClicked`
- [workspace] renamed `toDiposeOnUpdateCurrentWidget` to `toDisposeOnUpdateCurrentWidget`

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto committed Mar 26, 2020
1 parent 913134a commit f5433ec
Show file tree
Hide file tree
Showing 48 changed files with 89 additions and 84 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## v0.17.0

- [preferences] add a new preference to silence notifications [#7195](https://github.com/eclipse-theia/theia/pull/7195)
- [core] fixed keybindings for special Numpad keys in editors [#7315]
- [core] fixed keybindings for special Numpad keys in editors [#7315]

Breaking changes:

Expand All @@ -13,6 +13,11 @@ Breaking changes:
- [task] `TaskRestartRunningQuickOpenItem` class is renamed into `RunningTaskQuickOpenItem`. [7392](https://github.com/eclipse-theia/theia/pull/7392)
- [task] `TaskAttachQuickOpenItem` class is removed. [7392](https://github.com/eclipse-theia/theia/pull/7392)
- [task] `TaskService.taskProviderRegistry` is removed. [7418](https://github.com/eclipse-theia/theia/pull/7418)
- [debug] renamed `debuggingStaturBar` to `debuggingStatusBar` [#7409](https://github.com/eclipse-theia/theia/pull/7409)
- [plugin] renamed `CancelationTokenImpl` to `CancellationTokenImpl` [#7409](https://github.com/eclipse-theia/theia/pull/7409)
- [plugin] renamed `VIEW_ITEM_INLINE_MNUE` to `VIEW_ITEM_INLINE_MENU` [#7409](https://github.com/eclipse-theia/theia/pull/7409)
- [terminal] renamed `handleWroleWordOptionClicked` to `handleWholeWordOptionClicked` [#7409](https://github.com/eclipse-theia/theia/pull/7409)
- [workspace] renamed `toDiposeOnUpdateCurrentWidget` to `toDisposeOnUpdateCurrentWidget` [#7409](https://github.com/eclipse-theia/theia/pull/7409)

## v0.16.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { CurrentEditorAccess } from './current-editor-access';
import { CallHierarchyServiceProvider } from './callhierarchy-service';
import URI from '@theia/core/lib/common/uri';

export const CALL_HIERARCHY_TOGGLE_COMMAND_ID = 'callhierachy:toggle';
export const CALL_HIERARCHY_TOGGLE_COMMAND_ID = 'callhierarchy:toggle';
export const CALL_HIERARCHY_LABEL = 'Call Hierarchy';

export namespace CallHierarchyCommands {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe('Preference Service', () => {
done();
return;
}
done(new Error('onPreferenceChanged() fails to return any preference change infomation'));
done(new Error('onPreferenceChanged() fails to return any preference change information'));
return;
});

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/browser/quick-open/quick-title-bar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export class QuickTitleBar {
this.titleElement.innerText = innerTitle;
}

// Left buttons are for the buttons dervied from QuickInputButtons
// Left buttons are for the buttons derived from QuickInputButtons
private getLeftButtons(): ReadonlyArray<QuickTitleButton> {
if (this._buttons === undefined || this._buttons.length === 0) {
return [];
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/browser/shell/application-shell.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1722,7 +1722,7 @@ export namespace ApplicationShell {
* if optional then a user will be prompted
* if undefined then close will be canceled
* if true then will be saved on close
* if falase then won't be saved on close
* if false then won't be saved on close
*/
save?: boolean | undefined
}
Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/common/resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export interface Resource extends Disposable {
*/
readonly version?: ResourceVersion | undefined;
/**
* Reads latest content of this resouce.
* Reads latest content of this resource.
*
* If a resource supports versioning it updates version to latest.
*
Expand All @@ -66,7 +66,7 @@ export interface Resource extends Disposable {
*/
saveContents?(content: string, options?: ResourceSaveOptions): Promise<void>;
/**
* Applies incemental content changes to this resource.
* Applies incremental content changes to this resource.
*
* If a resource supports versioning clients can pass some version
* to check against it, if it is not provided latest version is used.
Expand Down Expand Up @@ -106,7 +106,7 @@ export namespace Resource {
return true;
} catch (e) {
if (!ResourceError.NotFound.is(e) && !ResourceError.OutOfSync.is(e)) {
console.error(`Failed to apply incremenal changes to '${resource.uri.toString()}':`, e);
console.error(`Failed to apply incremental changes to '${resource.uri.toString()}':`, e);
}
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export namespace DebugCommands {
export const REMOVE_ALL_WATCH_EXPRESSIONS: Command = {
id: 'debug.watch.removeAllExpressions',
category: DEBUG_CATEGORY,
label: 'Remove All Watch Expresssions'
label: 'Remove All Watch Expressions'
};
}
export namespace DebugThreadContextCommands {
Expand Down Expand Up @@ -1294,13 +1294,13 @@ export class DebugFrontendApplicationContribution extends AbstractViewContributi
}

protected updateStatusBar(): void {
if (this.debuggingStaturBar === document.body.classList.contains('theia-mod-debugging')) {
if (this.debuggingStatusBar === document.body.classList.contains('theia-mod-debugging')) {
return;
}
document.body.classList.toggle('theia-mod-debugging');
}

protected get debuggingStaturBar(): boolean {
protected get debuggingStatusBar(): boolean {
if (this.manager.state < DebugState.Running) {
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class DebugBreakpointWidget implements Disposable {
if (this.context === 'condition') {
overwriteBefore = position.column - 1;
} else {
// Inside the currly brackets, need to count how many useful characters are behind the position so they would all be taken into account
// Inside the curly brackets, need to count how many useful characters are behind the position so they would all be taken into account
const value = editor.getModel()!.getValue();
while ((position.column - 2 - overwriteBefore >= 0)
&& value[position.column - 2 - overwriteBefore] !== '{' && value[position.column - 2 - overwriteBefore] !== ' ') {
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/view/debug-watch-expression.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class DebugWatchExpression extends ExpressionItem {
}

protected setResult(body?: DebugProtocol.EvaluateResponse['body']): void {
// overriden to ignore error
// overridden to ignore error
super.setResult(body);
this.options.onDidChange();
}
Expand Down
18 changes: 9 additions & 9 deletions packages/file-search/src/node/file-search-service-impl.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,23 +164,23 @@ describe('search-service', function (): void {
const searchPattern = rootUri.path.dir.base;
const matches = await service.find(searchPattern, { rootUris: [rootUri.toString()], fuzzyMatch: false, useGitIgnore: true, limit: 200 });
for (const match of matches) {
const relativUri = rootUri.relative(new URI(match));
assert.notEqual(relativUri, undefined);
const relativMatch = relativUri!.toString();
assert.notEqual(relativMatch.indexOf(searchPattern), -1, relativMatch);
const relativeUri = rootUri.relative(new URI(match));
assert.notEqual(relativeUri, undefined);
const relativeMatch = relativeUri!.toString();
assert.notEqual(relativeMatch.indexOf(searchPattern), -1, relativeMatch);
}
});

it('fuzzy', async () => {
const matches = await service.find('shell', { rootUris: [rootUri.toString()], fuzzyMatch: true, useGitIgnore: true, limit: 200 });
for (const match of matches) {
const relativUri = rootUri.relative(new URI(match));
assert.notEqual(relativUri, undefined);
const relativMatch = relativUri!.toString();
const relativeUri = rootUri.relative(new URI(match));
assert.notEqual(relativeUri, undefined);
const relativeMatch = relativeUri!.toString();
let position = 0;
for (const ch of 'shell') {
position = relativMatch.indexOf(ch, position);
assert.notEqual(position, -1, relativMatch);
position = relativeMatch.indexOf(ch, position);
assert.notEqual(position, -1, relativeMatch);
}
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export class FileTreeWidget extends TreeWidget {

protected getPaddingLeft(node: TreeNode, props: NodeProps): number {
if (this.hidesExplorerArrows) {
// aditional left padding instead of top-level expansion toggle
// additional left padding instead of top-level expansion toggle
return super.getPaddingLeft(node, props) + this.props.leftPadding;
}
return super.getPaddingLeft(node, props);
Expand Down
2 changes: 1 addition & 1 deletion packages/git/src/browser/git-repository-tracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export class GitRepositoryTracker {
}

/**
* Returns the last known status of the selected respository, or `undefined` if no repositories are available.
* Returns the last known status of the selected repository, or `undefined` if no repositories are available.
*/
get selectedRepositoryStatus(): WorkingDirectoryStatus | undefined {
return this.workingDirectoryStatus;
Expand Down
2 changes: 1 addition & 1 deletion packages/git/src/node/git-repository-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class GitRepositoryManager {
protected async sync(repository: Repository): Promise<void> {
const reference = await this.getWatcher(repository);
const watcher = reference.object;
// dispose the reference once the next sync cycle is actaully completed
// dispose the reference once the next sync cycle is actually completed
watcher.sync().then(() => reference.dispose());
}

Expand Down
4 changes: 2 additions & 2 deletions packages/keymaps/src/browser/keymaps-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export class KeymapsService {
// TODO use preference values to get proper json settings
// TODO handle dirty models properly
// TODO handle race conditions properly
// TODO only apply mimimal edits
// TODO only apply minimal edits
await this.resource.saveContents(JSON.stringify(keybindings, undefined, 4));
}

Expand All @@ -157,7 +157,7 @@ export class KeymapsService {
// TODO use preference values to get proper json settings
// TODO handle dirty models properly
// TODO handle race conditions properly
// TODO only apply mimimal edits
// TODO only apply minimal edits
await this.resource.saveContents(JSON.stringify(filtered, undefined, 4));
}

Expand Down
2 changes: 1 addition & 1 deletion packages/languages/src/common/language-selector/glob.ts
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ function parseRegExp(pattern: string): string {
return regEx;
}

// regexes to check for trival glob patterns that just check for String#endsWith
// regexes to check for trivial glob patterns that just check for String#endsWith
const T1 = /^\*\*\/\*\.[\w\.-]+$/; // **/*.something
const T2 = /^\*\*\/([\w\.-]+)\/?$/; // **/something
const T3 = /^{\*\*\/[\*\.]?[\w\.-]+\/?(,\*\*\/[\*\.]?[\w\.-]+\/?)*}$/; // {**/*.something,**/*.else} or {**/package.json,**/project.json}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { NotificationContentRenderer } from './notification-content-renderer';

describe('notification-content-renderer', () => {

const contentRnderer = new NotificationContentRenderer();
const contentRenderer = new NotificationContentRenderer();

it('should remove new lines', () => {
expectRenderedContent('foo\nbar', 'foo bar');
Expand Down Expand Up @@ -70,6 +70,6 @@ describe('notification-content-renderer', () => {
});

const expectRenderedContent = (input: string, output: string) =>
expect(contentRnderer.renderMessage(input)).to.be.equal(output);
expect(contentRenderer.renderMessage(input)).to.be.equal(output);

});
4 changes: 2 additions & 2 deletions packages/monaco/src/browser/monaco-editor-provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export class MonacoEditorProvider {

/**
* Suppresses Monaco keydown listener to avoid triggering default Monaco keybindings
* if they are overriden by a user. Monaco keybindings should be registered as Theia keybindings
* if they are overridden by a user. Monaco keybindings should be registered as Theia keybindings
* to allow a user to customize them.
*/
protected suppressMonacoKeybindingListener(editor: MonacoEditor): void {
Expand Down Expand Up @@ -359,7 +359,7 @@ export class MonacoEditorProvider {
referencesController._ignoreModelChangeEvent = true;
const range = monaco.Range.lift(ref.range).collapseToStart();

// prerse the model that it does not get disposed if an editor preview replaces an editor
// preserve the model that it does not get disposed if an editor preview replaces an editor
const model = referencesController._model;
referencesController._model = undefined;

Expand Down
4 changes: 2 additions & 2 deletions packages/monaco/src/browser/monaco-editor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -511,9 +511,9 @@ export class MonacoEditor extends MonacoEditorServices implements TextEditor {
}
}

protected fireLanguageChanged(langaugeId: string): void {
protected fireLanguageChanged(languageId: string): void {
this._languageAutoDetected = false;
this.onLanguageChangedEmitter.fire(langaugeId);
this.onLanguageChangedEmitter.fire(languageId);
}

getResourceUri(): URI {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class MonacoSemanticHighlightingService extends SemanticHighlightingServi
protected readonly toDisposeOnEditorClose = new Map<string, Disposable>();
protected readonly toDisposeOnUnregister = new Map<string, Disposable>();

// laguage id -> (scope index -> decoration type)
// language id -> (scope index -> decoration type)
protected readonly decorationTypes = new Map<string, Map<number, DecorationTypeInfo>>();

private lastDecorationTypeId: number = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,14 @@ export class MonacoSnippetSuggestProvider implements monaco.languages.Completion
});
}
if (endsInWhitespace || lineOffsets.length === 0) {
// add remaing snippets when the current prefix ends in whitespace or when no
// add remaining snippets when the current prefix ends in whitespace or when no
// interesting positions have been found
availableSnippets.forEach(snippet => {
suggestions.push(new MonacoSnippetSuggestion(snippet, monaco.Range.fromPositions(position)));
});
}

// dismbiguate suggestions with same labels
// disambiguate suggestions with same labels
suggestions.sort(MonacoSnippetSuggestion.compareByLabel);
return { suggestions };
}
Expand Down Expand Up @@ -134,7 +134,7 @@ export class MonacoSnippetSuggestProvider implements monaco.languages.Completion
}

/**
* should NOT throw to prevent load erros on suggest
* should NOT throw to prevent load errors on suggest
*/
protected async loadURI(uri: string | URI, options: SnippetLoadOptions, toDispose: DisposableCollection): Promise<void> {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class MonacoThemeRegistry {
}

setTheme(name: string, data: ThemeMix): void {
// monaco auto refrehes a theme with new data
// monaco auto refreshes a theme with new data
monaco.editor.defineTheme(name, data);
}

Expand Down
4 changes: 2 additions & 2 deletions packages/plugin-dev/src/browser/hosted-plugin-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class HostedPluginController implements FrontendApplicationContribution {
protected readonly messageService: MessageService;

private pluginState: HostedInstanceState = HostedInstanceState.STOPPED;
// used only for displaying Running insted of Watching in status bar if run of watcher fails
// used only for displaying Running instead of Watching in status bar if run of watcher fails
private watcherSuccess: boolean;
private entry: StatusBarEntry | undefined;

Expand Down Expand Up @@ -251,7 +251,7 @@ export class HostedPluginController implements FrontendApplicationContribution {
}

/**
* Updaing status bar element when changing connection status.
* Updating status bar element when changing connection status.
*/
private onConnectionStatusChanged(): void {
if (this.connectionStatusService.currentStatus === ConnectionStatus.OFFLINE) {
Expand Down
4 changes: 2 additions & 2 deletions packages/plugin-dev/src/node/hosted-plugins-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const HostedPluginsManager = Symbol('HostedPluginsManager');
export interface HostedPluginsManager {

/**
* Runs watcher script to recomple plugin on any changes along given path.
* Runs watcher script to recompile plugin on any changes along given path.
*
* @param uri uri to plugin root folder.
*/
Expand All @@ -42,7 +42,7 @@ export interface HostedPluginsManager {
stopWatchCompilation(uri: string): Promise<void>;

/**
* Chacks if watcher script to recomple plugin is running.
* Checks if watcher script to recompile plugin is running.
*
* @param uri uri to plugin root folder.
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/plugin-ext/src/common/plugin-api-rpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export interface TerminalServiceMain {
$hide(id: string): void;

/**
* Distroy terminal.
* Destroy terminal.
* @param id - terminal id.
*/
$dispose(id: string): void;
Expand Down Expand Up @@ -1241,7 +1241,7 @@ export interface LanguagesMain {
$registerWorkspaceSymbolProvider(handle: number, pluginInfo: PluginInfo): void;
$registerFoldingRangeProvider(handle: number, pluginInfo: PluginInfo, selector: SerializedDocumentFilter[]): void;
$registerDocumentColorProvider(handle: number, pluginInfo: PluginInfo, selector: SerializedDocumentFilter[]): void;
$registerRenameProvider(handle: number, pluginInfo: PluginInfo, selector: SerializedDocumentFilter[], supportsResoveInitialValues: boolean): void;
$registerRenameProvider(handle: number, pluginInfo: PluginInfo, selector: SerializedDocumentFilter[], supportsResolveInitialValues: boolean): void;
$registerCallHierarchyProvider(handle: number, selector: SerializedDocumentFilter[]): void;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-ext/src/common/rpc-protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ class MessageFactory {
/**
* These functions are responsible for correct transferring objects via rpc channel.
*
* To reach that some specific kind of objects is converteed to json in some custom way
* To reach that some specific kind of objects is converted to json in some custom way
* and then, after receiving, revived to objects again,
* so there is feeling that object was transferred via rpc channel.
*
Expand Down
4 changes: 2 additions & 2 deletions packages/plugin-ext/src/hosted/browser/hosted-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,8 @@ export class HostedPluginSupport {
// process empty plugins as well in order to properly remove stale plugin widgets
await this.syncPlugins();

// it has to be resolved before awaiting layout is initilization
// otherwise clients can hang forever in the initializatin phase
// it has to be resolved before awaiting layout is initialized
// otherwise clients can hang forever in the initialization phase
this.deferredWillStart.resolve();

// make sure that the previous state, including plugin widgets, is restored
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-ext/src/hosted/node/plugin-host.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ process.on('unhandledRejection', (reason: any, promise: Promise<any>) => {
promise.catch(err => {
unhandledPromises.splice(index, 1);
if (terminating && (ConnectionClosedError.is(err) || ConnectionClosedError.is(reason))) {
// during termination it is expected that pending rpc requerst are rejected
// during termination it is expected that pending rpc request are rejected
return;
}
console.error(`Promise rejection not handled in one second: ${err} , reason: ${reason}`);
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-ext/src/hosted/node/plugin-reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class HostedPluginReader implements BackendApplicationContribution {
if (localPath) {
res.sendFile(filePath, { root: localPath }, e => {
if (!e) {
// the file was found and successfully transfered
// the file was found and successfully transferred
return;
}
console.error(`Could not transfer '${filePath}' file from '${pluginId}'`, e);
Expand Down
Loading

0 comments on commit f5433ec

Please sign in to comment.