terminal: fix color theming #7325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
terminal
|
@varmanishant would you like to review? :) |
akosyakov
reviewed
Mar 12, 2020
Fixes #7280 This commit fixes the issue where VS Code terminal theming was not applied correctly. Since the VS Code theming options for terminals and the `xterm` ITheme differed (lower-case first letter), the terminal themes were not applied properly. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/GH-7280
branch
from
98be178 to
a1a6deb
Compare
|
@vince-fugnitto This looks good! |
akosyakov
approved these changes
Mar 12, 2020
lmcbout
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
Works nicely
Tested on Chrome, Firefox and electron on Ubuntu 18.04
Thanks @vince-fugnitto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #7280
This commit fixes the issue where VS Code terminal theming was not applied correctly. Since the VS Code theming options for terminals and the
xtermITheme differed (lower-case), the terminal themes were not applied properly.How to test
ls -al)Examples:
Dark+
Tomorrow Night Blue
Abyss
Light+
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]