-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terminal: fix terminal theming #7280
Comments
It looks like we have logic already to handle the foreground colors but they do not seem to be applied properly:
|
It should be already supported:
Maybe some regression. |
One problem that I noticed is that, when we do |
Here is a simple correction that can be applied here to make it load from the theme correctly:
|
Fixes #7280 This commit fixes the issue where VS Code terminal theming was not applied correctly. Since the VS Code theming options for terminals and the `xterm` ITheme differed (lower-case), the terminal themes were not applied properly. Signed-off-by: Vincent Fugnitto <[email protected]>
Fixes #7280 This commit fixes the issue where VS Code terminal theming was not applied correctly. Since the VS Code theming options for terminals and the `xterm` ITheme differed (lower-case first letter), the terminal themes were not applied properly. Signed-off-by: Vincent Fugnitto <[email protected]>
Fixes #7280 This commit fixes the issue where VS Code terminal theming was not applied correctly. Since the VS Code theming options for terminals and the `xterm` ITheme differed (lower-case first letter), the terminal themes were not applied properly. Signed-off-by: Vincent Fugnitto <[email protected]>
Description
terminal theming from VS Code theming extensions does not work properly.
For example, the vscode-builtin-theme-tomorrow-night-blue theme contributes colors to the terminal:
Theia
VS Code
The text was updated successfully, but these errors were encountered: