git: skip failing git unit test on win

[vince-fugnitto]

What it does

Fixes #7064

Fixes the failing git unit test by making it more robust to problems caused as described in #933.

Note:

I understand that the original error might require more fundamental changes to git for Windows but since we will soon be migrating to the builtins, I thought it'd be low effort to get the CI to pass successfully.

How to test

Verify that the tests during CI for @theia/git successfully pass.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Vincent Fugnitto [email protected]

[paul-marechal]

CI is green again, LGTM.

[paul-marechal]

Although, is it really normal to get duplicate repositories back?

[vince-fugnitto]

Although, is it really normal to get duplicate repositories back?

No but it looks to be a complex issue #933 with Windows.
I thought that since @theia/git would be deprecated soon we should fix the CI for the moment.

[vince-fugnitto]

@kittaakos are you against such a change?
I understand we lose the exactness of the unit test but I thought that it could be a temporary measure since:

• it fixes the failing CI for all new pull-requests
• the @theia/git will be removed in favor of vscode-builtin-git and vscode-builtin-git-ui in the future
• the problem [git][Windows] Repository locator test failure on Windows #933 is quite old and has yet to be resolved which leads me to conclude it is a difficult and complex problem

[kittaakos]

are you against such a change?

No, I do not, but I'd need a little bit more time to dig into; next week 😕 As a quick fix for now, can we skip the test on Windows?

[vince-fugnitto]

are you against such a change?

No, I do not, but I'd need a little bit more time to dig into; next week 😕 As a quick fix for now, can we skip the test on Windows?

Sure, I can update the pull-request to skip the test on Windows for the moment :)

[kittaakos]

Sure, I can update the pull-request to skip the test on Windows for the moment :)

It's your call; whichever is easier for you. Skipping the test on Windows seems to be a bit more straightforward "fix".

[kittaakos]

Looks good to me! Thank you for taking care of the CI, @vince-fugnitto 👍

Please proceed with the merging once you see the green builds.