Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build failure on windows during @theia/git unit test #7064

Closed
vince-fugnitto opened this issue Feb 4, 2020 · 3 comments · Fixed by #7068
Closed

ci: build failure on windows during @theia/git unit test #7064

vince-fugnitto opened this issue Feb 4, 2020 · 3 comments · Fixed by #7068
Labels
bug bugs found in the application ci issues related to CI / tests help wanted issues meant to be picked up, require help OS/Windows issues related to the Windows OS

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Feb 4, 2020

Description

There is a recent Windows CI failure for one of the unit tests present in the @theia/git extension.

it('should discover all nested repositories and the root repository which is at the workspace root', async () => {
const root = track.mkdirSync('discovery-test-3');
fs.mkdirSync(path.join(root, 'BASE'));
fs.mkdirSync(path.join(root, 'BASE', 'A'));
fs.mkdirSync(path.join(root, 'BASE', 'B'));
fs.mkdirSync(path.join(root, 'BASE', 'C'));
const git = await createGit();
await initRepository(path.join(root, 'BASE'));
await initRepository(path.join(root, 'BASE', 'A'));
await initRepository(path.join(root, 'BASE', 'B'));
await initRepository(path.join(root, 'BASE', 'C'));
const workspaceRootUri = FileUri.create(path.join(root, 'BASE')).toString();
const repositories = await git.repositories(workspaceRootUri, {});
expect(repositories.map(r => path.basename(FileUri.fsPath(r.localUri))).sort()).to.deep.equal(['A', 'B', 'BASE', 'C']);
});

Examples:

@vince-fugnitto vince-fugnitto added bug bugs found in the application help wanted issues meant to be picked up, require help OS/Windows issues related to the Windows OS ci issues related to CI / tests labels Feb 4, 2020
@vince-fugnitto
Copy link
Member Author

The tests seem to pass locally on a Windows machine, not sure as to why the tests are failing suddenly at the moment.

@kittaakos
Copy link
Contributor

Related? #933

@vince-fugnitto
Copy link
Member Author

Related? #933

Yes, it looks like it is possibly related to #933

vince-fugnitto added a commit that referenced this issue Feb 4, 2020
Fixes #7064

Fixes the failing `git` unit test by making it more robust to
problems caused as described in #933.

Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Feb 5, 2020
Fixes #7064

Skips the failing `@theia/git` unit test on Windows (#933).

Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Feb 5, 2020
Fixes #7064

Skips the failing `@theia/git` unit test on Windows (#933).

Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Feb 5, 2020
Fixes #7064

Skips the failing `@theia/git` unit test on Windows (#933).

Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Feb 5, 2020
Fixes #7064

Skips the failing `@theia/git` unit test on Windows (#933).

Signed-off-by: Vincent Fugnitto <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Fixes eclipse-theia#7064

Skips the failing `@theia/git` unit test on Windows (eclipse-theia#933).

Signed-off-by: Vincent Fugnitto <[email protected]>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
Fixes eclipse-theia#7064

Skips the failing `@theia/git` unit test on Windows (eclipse-theia#933).

Signed-off-by: Vincent Fugnitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application ci issues related to CI / tests help wanted issues meant to be picked up, require help OS/Windows issues related to the Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants