Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug] fix typos present in 'debug' extension #6698

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

  • renamed command COPY_VAIRABLE_VALUE to COPY_VARIABLE_VALUE.
  • renamed command COPY_VAIRABLE_AS_EXPRESSION to COPY_VARIABLE_AS_EXPRESSION.
  • renamed getter method multiSesssion to multiSession.
  • fixed additional typos.

How to test

  • verify that CI successfully passes (build & test of the @theia/debug extension)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the debug issues that related to debug functionality label Dec 5, 2019
@vince-fugnitto vince-fugnitto self-assigned this Dec 5, 2019
- renamed command `COPY_VAIRABLE_VALUE` to `COPY_VARIABLE_VALUE`.
- renamed command `COPY_VAIRABLE_AS_EXPRESSION` to `COPY_VARIABLE_AS_EXPRESSION`.
- renamed getter method `multiSesssion` to `multiSession`.
- fixed additional typos.

Signed-off-by: vince-fugnitto <[email protected]>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm fine with renaming, probably does not break anybody. cc @tolusha @thegecko

@vince-fugnitto vince-fugnitto merged commit 0e64f11 into master Dec 9, 2019
@vince-fugnitto vince-fugnitto deleted the vf/debug-typos branch December 9, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants