Skip to content

Commit

Permalink
Fix typos present in 'debug' extension
Browse files Browse the repository at this point in the history
- renamed command `COPY_VAIRABLE_VALUE` to `COPY_VARIABLE_VALUE`.
- renamed command `COPY_VAIRABLE_AS_EXPRESSION` to `COPY_VARIABLE_AS_EXPRESSION`.
- renamed getter method `multiSesssion` to `multiSession`.
- fixed additional typos.

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto committed Dec 5, 2019
1 parent b6daa53 commit 87d9f1a
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 10 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Breaking changes:

- [core] new browser windows spawned through opener-service have noopener set, preventing them from accessing window.opener and giving them their own event loop. openNewWindow will no longer return a Window as a result.
- [terminal] renamed `TerminalCopyOnSelectionHander` to `TerminalCopyOnSelectionHandler` [#6692](https://github.com/eclipse-theia/theia/pull/6692)
- [debug] renamed command `COPY_VARAIBLE_AS_EXPRESSION` to `COPY_VARIABLE_AS_EXPRESSION` []()
- [debug] renamed command `COPY_VARAIBLE_VALUE` to `COPY_VARIABLE_VALUE` []()
- [debug] renamed getter method `multiSesssion` to `multiSession` []()

## v0.13.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ export namespace DebugCommands {
category: DEBUG_CATEGORY,
label: 'Set Value',
};
export const COPY_VAIRABLE_VALUE: Command = {
export const COPY_VARIABLE_VALUE: Command = {
id: 'debug.variable.copyValue',
category: DEBUG_CATEGORY,
label: 'Copy Value',
};
export const COPY_VAIRABLE_AS_EXPRESSION: Command = {
export const COPY_VARIABLE_AS_EXPRESSION: Command = {
id: 'debug.variable.copyAsExpression',
category: DEBUG_CATEGORY,
label: 'Copy As Expression',
Expand Down Expand Up @@ -477,8 +477,8 @@ export class DebugFrontendApplicationContribution extends AbstractViewContributi

registerMenuActions(DebugVariablesWidget.CONTEXT_MENU,
DebugCommands.SET_VARIABLE_VALUE,
DebugCommands.COPY_VAIRABLE_VALUE,
DebugCommands.COPY_VAIRABLE_AS_EXPRESSION
DebugCommands.COPY_VARIABLE_VALUE,
DebugCommands.COPY_VARIABLE_AS_EXPRESSION
);

registerMenuActions(DebugBreakpointsWidget.EDIT_MENU,
Expand Down Expand Up @@ -737,12 +737,12 @@ export class DebugFrontendApplicationContribution extends AbstractViewContributi
isEnabled: () => !!this.selectedVariable && this.selectedVariable.supportSetVariable,
isVisible: () => !!this.selectedVariable && this.selectedVariable.supportSetVariable
});
registry.registerCommand(DebugCommands.COPY_VAIRABLE_VALUE, {
registry.registerCommand(DebugCommands.COPY_VARIABLE_VALUE, {
execute: () => this.selectedVariable && this.selectedVariable.copyValue(),
isEnabled: () => !!this.selectedVariable && this.selectedVariable.supportCopyValue,
isVisible: () => !!this.selectedVariable && this.selectedVariable.supportCopyValue
});
registry.registerCommand(DebugCommands.COPY_VAIRABLE_AS_EXPRESSION, {
registry.registerCommand(DebugCommands.COPY_VARIABLE_AS_EXPRESSION, {
execute: () => this.selectedVariable && this.selectedVariable.copyAsExpression(),
isEnabled: () => !!this.selectedVariable && this.selectedVariable.supportCopyAsExpression,
isVisible: () => !!this.selectedVariable && this.selectedVariable.supportCopyAsExpression
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ describe('Launch Preferences', () => {
assert.deepStrictEqual(JSON.parse(JSON.stringify(config)), expectation);
});

testIt('get from undefind', () => {
testIt('get from undefined', () => {
const config = preferences.get('launch', undefined, undefined);
assert.deepStrictEqual(JSON.parse(JSON.stringify(config)), expectation);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/view/debug-threads-source.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class DebugThreadsSource extends TreeSource {
this.toDispose.push(this.model.onDidChange(() => this.fireDidChange()));
}

get multiSesssion(): boolean {
get multiSession(): boolean {
return this.model.sessionCount > 1;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/view/debug-threads-widget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class DebugThreadsWidget extends SourceTreeWidget {
}

protected getDefaultNodeStyle(node: TreeNode, props: NodeProps): React.CSSProperties | undefined {
if (this.threads.multiSesssion) {
if (this.threads.multiSession) {
return super.getDefaultNodeStyle(node, props);
}
return undefined;
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/common/debug-model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import { IJSONSchema, IJSONSchemaSnippet } from '@theia/core/lib/common/json-sch
import { Disposable } from '@theia/core/lib/common/disposable';
import { MaybePromise } from '@theia/core/lib/common/types';

// FXIME: break down this file to debug adapter and debug adapter contribution (see Theia file naming conventions)
// FIXME: break down this file to debug adapter and debug adapter contribution (see Theia file naming conventions)

/**
* DebugAdapterSession symbol for DI.
Expand Down

0 comments on commit 87d9f1a

Please sign in to comment.