Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6618: Reuse terminal based both on label and caption of the term… #6619

Merged

Conversation

a1994846931931
Copy link
Contributor

@a1994846931931 a1994846931931 commented Nov 25, 2019

…inal title

Signed-off-by: Cai Xuye [email protected]

What it does

A simple approach to fix #6618 - may not be the best solution, but does what it does.

How to test

  1. Install VSCode's python plugin
  2. Debug with the following configuration ( console should be integratedTerminal )
    {
      "name": "Python: Current File",
      "type": "python",
      "request": "launch",
      "program": "${file}",
      "console": "integratedTerminal"
    }
  1. End the debug session but keep the integrated terminal. Then run another debug session and see how theia lanches it in the same terminal launched before.

python-integrated-fix

Review checklist

Reminder for reviewers

@akosyakov akosyakov requested a review from tolusha November 25, 2019 12:09
@akosyakov akosyakov added the debug issues that related to debug functionality label Nov 25, 2019
@akosyakov akosyakov requested a review from elaihau November 25, 2019 12:09
@tolusha
Copy link
Contributor

tolusha commented Nov 25, 2019

I can't validate the PR since I can't reproduce the case when fix is needed, but code looks good for me.

@a1994846931931
Copy link
Contributor Author

I can't validate the PR since I can't reproduce the case when fix is needed, but code looks good for me.

@tolusha
Hi, I forgot to mention that it's VSCode's python extension. Could you please try to reproduce it again?

@elaihau
Copy link
Contributor

elaihau commented Nov 26, 2019

@tolusha
Hi, I forgot to mention that it's VSCode's python extension. Could you please try to reproduce it again?

OK I finally reproduced the error.
@tolusha if you want to try in your environment, please make sure install this extension https://marketplace.visualstudio.com/items?itemName=ms-python.python, not the vscode built-in python extension.

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the issue is fixed with this change.

@akosyakov
Copy link
Member

i'm not sure that @a1994846931931 has commit rights, please help with merging after the approve, cc @elaihau

@elaihau elaihau merged commit 6f38e4f into eclipse-theia:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated terminal cannot be reused
4 participants