Integrated terminal cannot be reused

[a1994846931931]

Description

Theia can now support integrated terminal, thanks to commit 0327a4d. But there remains a problem that the terminal cannot be reused (see the posted gif below).

Reproduction Steps

1. Install python plugin (from VSCode marketplace)
2. Debug with the following configuration ( console should be integratedTerminal )

    {
      "name": "Python: Current File",
      "type": "python",
      "request": "launch",
      "program": "${file}",
      "console": "integratedTerminal"
    }

3. End the debug session but keep the integrated terminal. Then run another debug session and see how theia lanch it in a new terminal.

OS and Theia version:
OS: Ubuntu
Version: 145f913

Diagnostics:
In line

theia/packages/debug/src/browser/debug-session.tsx

Line 377 in 145f913

let terminal = this.terminalServer.all.find(t => t.title.label === options.title);

The options.title is compared with t.title.label, but t.title.label changes.

[akosyakov]

@elaihau Would it be possible to refactor tasks that they preserve identity as in VS Code? It breaks in many places not only for debugging. Generally running the same task multiple times should NOT be allowed and the same terminal should be used. Right now it is most annoying mismatch.

[elaihau]

@a1994846931931
quick question: is the python plugin mentioned in this ticket

• the python extension in Theia, or
• the python extension from vsCode?

I was getting a "The debug session type "python" is not supported." error when tried to reproduce this error. Could you please advise what I should do to make debugging python code work?

Thanks !

[a1994846931931]

@a1994846931931
quick question: is the python plugin mentioned in this ticket

• the python extension in Theia, or
• the python extension from vsCode?

I was getting a "The debug session type "python" is not supported." error when tried to reproduce this error. Could you please advise what I should do to make debugging python code work?

Thanks !

@elaihau
Hi, sorry I forgot to mention that it's VSCode's python extension.