Display 'path' when creating a new file/folder

[vince-fugnitto]

What it does

Fixes #6544

• displays the parent path when attempting to create a new file (path in which the file is created at).
• displays the parent path when attempting to create a new folder (path in which the folder is created at).
• when the URI selection from the explorer is at the workspace root display the entire path.
• when the URI selection from the explorer is not the workspace root, display the relative path (ex: packages/core/src/common).
• introduces the WorkspaceInputDialog dialog.
• introduces the WorkspaceInputDialogProps which has a new parentUri prop

Example:

Workspace Root URI Selection

Non-workspace Root URI Selection

How to test

1. verify the parent path is correct when opening the new file dialog (verify multiple locations)
   • parent path corresponds to the URI selection present in the explorer.
     • when selecting the workspace root or URI present in the root display the full path
     • when selecting non-workspace root, display the relative path
2. verify the parent path is correct when opening the new folder dialog (verify multiple locations)
   • parent path corresponds to the URI selection present in the explorer.
     • when selecting the workspace root or URI present in the root display the full path
     • when selecting non-workspace root, display the relative path
3. repeat for multi-root workspaces

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[kittaakos]

Why do not we use path: Path (where Path is from @theia/core/core/lib/common/path)? No need to clarify the property with the "The general path" JSDoc which is not clear by the way.

[kittaakos]

This is a nice to have UI/UX feature 👍

Dropping the input dialogs and doing what VS Code does when creating a new file/folder would be better in the long run.

[kittaakos]

Example:

This behaves differently on Windows. Based on the screenshot you have attached, I should see the full FS path, but I see a project relative path on Windows.

What it does

Fixes #6544

• displays path when attempting to create a new file.
• displays path when attempting to create a new folder.

Also, it is not clear what path means.

[vince-fugnitto]

@kittaakos thank you for the review, I adjusted the code and documentation (including the PR description) to be more explicit. Please let me know if you have additional feedback.

[kittaakos]

additional feedback.

I have tried it; it works as described 👍

Why do we distinguish between the root and other folders? I am wondering why don't we always show WS-root relative paths? Smells like a hack in the label provider.

[vince-fugnitto]

additional feedback.

I have tried it; it works as described

Why do we distinguish between the root and other folders? I am wondering why don't we always show WS-root relative paths? Smells like a hack in the label provider.

Right, I'm not doing any special logic with creating the label besides using the labelProvider.
Perhaps you are right and that it should be properly updated.

[kittaakos]

I have verified it on Windows with the browser example; it works as expected 👍

[kittaakos]

Why do we distinguish between the root and other folders? I am wondering why don't we always show WS-root relative paths? Smells like a hack in the label provider.

Follow-up: #6549

[vince-fugnitto]

I have verified it on Windows with the browser example; it works as expected

Thank you for the review !