Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display path to a new file in create file/folder dialog #6544

Closed
akosyakov opened this issue Nov 13, 2019 · 2 comments · Fixed by #6545
Closed

display path to a new file in create file/folder dialog #6544

akosyakov opened this issue Nov 13, 2019 · 2 comments · Fixed by #6545
Labels
filesystem issues related to the filesystem help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience

Comments

@akosyakov
Copy link
Member

Creation of a file based on a selection, sometimes it is tricky to figure out from UI where file is going to be created. Seeing the path would be helpful. One has to use LabelProvider.getLongName to get a proper path to display.

@akosyakov akosyakov added help wanted issues meant to be picked up, require help filesystem issues related to the filesystem ui/ux issues related to user interface / user experience labels Nov 13, 2019
@vince-fugnitto
Copy link
Member

@akosyakov do you propose we display the path directly in the file dialog?

@akosyakov
Copy link
Member Author

Yes, there is space above the input field.

vince-fugnitto added a commit that referenced this issue Nov 13, 2019
Fixes #6544

- displays `path` when attempting to create a new file.
- displays `path` when attempting to create a new folder.
- introduces the `WorkspaceInputDialog` dialog.
- introduces the `WorkspaceInputDialogProps` which has a new `path` prop.

Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Nov 14, 2019
Fixes #6544

- displays the parent `path` when attempting to create a new file (path in which the file is created at).
- displays the parent `path` when attempting to create a new folder (path in which the folder is created at).
- when the URI selection from the explorer is at the workspace root display the entire path.
- when the URI selection from the explorer is not the workspace root, display the relative path (ex: packages/core/src/common).
- introduces the `WorkspaceInputDialog` dialog.
- introduces the `WorkspaceInputDialogProps` which has a new `parentUri` prop.

Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Nov 15, 2019
Fixes #6544

- displays the parent `path` when attempting to create a new file (path in which the file is created at).
- displays the parent `path` when attempting to create a new folder (path in which the folder is created at).
- when the URI selection from the explorer is at the workspace root display the entire path.
- when the URI selection from the explorer is not the workspace root, display the relative path (ex: packages/core/src/common).
- introduces the `WorkspaceInputDialog` dialog.
- introduces the `WorkspaceInputDialogProps` which has a new `parentUri` prop.

Signed-off-by: vince-fugnitto <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Fixes eclipse-theia#6544

- displays the parent `path` when attempting to create a new file (path in which the file is created at).
- displays the parent `path` when attempting to create a new folder (path in which the folder is created at).
- when the URI selection from the explorer is at the workspace root display the entire path.
- when the URI selection from the explorer is not the workspace root, display the relative path (ex: packages/core/src/common).
- introduces the `WorkspaceInputDialog` dialog.
- introduces the `WorkspaceInputDialogProps` which has a new `parentUri` prop.

Signed-off-by: vince-fugnitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem issues related to the filesystem help wanted issues meant to be picked up, require help ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants