Rebind Go to Definition to ctrl+f11

[svor]

Signed-off-by: svor [email protected]

What it does

Sets ctrl+f11 as a default shortcut for Go to Definition command to avoid collision with Go to Implementation command.

Related issues:

• [editor]Cmd+F12, Go to Definition Shortcut doesn't work in the browser client #6410
• After updating Monaco Editor some Keybindings has collision for Java LS eclipse-che/che#14520

How to test

• Start Theia in the browser
• Open some java class and make sure that Java LS started
• Try to execute Go to Definition via ctrl+f11 and Go to Implementation via ctrl+f12

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@eclipse-theia/eclipse-theia Does anyone has objections, concerns about such keybinding?

[thegecko]

I don't think this raises any concerns.

[lmcbout]

Tested on Ubuntu
Works fine but I noticed that the keybinding "F12" in electron is for "Go to Definition" and in the browser, the keybinding is "ctrlcmd + f11".
Can we use the same keybindings with electron and the browser ?
In electron, "F12" is for "monaco.editor.gotoNextSymbolFromResult" but "ctrl+ f11" is not used

[svor]

@lmcbout Monaco uses F12 as a keybinding for Go to Definition if it is running not in the browser - it is default value, for the browser it is Ctrl+F12.

Can we use the same keybindings with electron and the browser ?

Yes, we can set Ctrl + F11 for the electron as well, but I'm not sure if it would be correct decision

[lmcbout]

@svor Thanks for the info.
I don't know if some end-users use the browser and the electron version, i don't , but if they do, it would be nice for them eventually to use the same keybindings.
So for this PR, works fine for me , no objections

[akosyakov]

thank you @svor!

[akosyakov]

Yes, we can set Ctrl + F11 for the electron as well, but I'm not sure if it would be correct decision

I think it is good to keep it align with VS Code. When VS Code team sorted out the issue in Monaco we can revert this fix.

[benoitf]

tested on macos