Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editor]Cmd+F12, Go to Definition Shortcut doesn't work in the browser client #6410

Closed
svor opened this issue Oct 17, 2019 · 0 comments
Closed

[editor]Cmd+F12, Go to Definition Shortcut doesn't work in the browser client #6410

svor opened this issue Oct 17, 2019 · 0 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco

Comments

@svor
Copy link
Contributor

svor commented Oct 17, 2019

Description

Go to Implementation and Go to Definition commands' shortcuts have collision, both of them use ctrl+f12 in the browser client. It happened because Go to Definition editor command was rebound from f12 to ctrl+f12 for browser clients in monaco.

Related issues:

Reproduction Steps

  • Open browser Theia client
  • Open Keyboard Shortcuts settings and take a look that Go to Definition and Go to Implementation have the same shortcuts

OS and Theia version:
Fedora 28
Theia v0.11.0
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco labels Oct 17, 2019
@svor svor mentioned this issue Oct 17, 2019
Merged
1 task
@svor svor closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svor @akosyakov