Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd+F12, Go to Definition Shortcut not working in browser #1407

Closed
Aayush04 opened this issue Apr 1, 2019 · 2 comments
Closed

Cmd+F12, Go to Definition Shortcut not working in browser #1407

Aayush04 opened this issue Apr 1, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@Aayush04
Copy link

Aayush04 commented Apr 1, 2019

monaco-editor version: 0.16.0
monaco-editor version: 0.14.0
Browser: Chrome
OS: MacOS

When running monaco-editor on browser
ShortCut for "Go to Definition" and "Go to Implementation" is same i.e. Cmd+F12
This can be seen in shortcut list also when pressing F1.

And due to this not able to trigger "Go to Definition" with Cmd+F12 , as "Go to Implentation" works instead.

I checked in the code it is written there also

var goToDeclarationKb = platform.isWeb 
                     ? 2048 /* CtrlCmd */ | 70 /* F12 */ : 70 /* F12 */;

and for goToImplementation

 kbOpts: {
                kbExpr: EditorContextKeys.editorTextFocus,
                primary: 2048 /* CtrlCmd */ | 70 /* F12 */,
                weight: 100 /* EditorContrib */
 }

that for web Shortcut for GotToDefiniton will Cmd+F12 but same is also assigned to GoToImplementation.

@tsmaeder
Copy link

Any opinions on this from the development team?

@alexdima
Copy link
Member

I believe this has been fixed in the meantime because now cmd+f12 jumps to definition for me on mac/chrome when running from sources.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants